docs: fix docstring on TestResponse.assertNotOk()#8585
Merged
kenjis merged 1 commit intocodeigniter4:developfrom Feb 26, 2024
rnazali:patch-1
Merged
docs: fix docstring on TestResponse.assertNotOk()#8585kenjis merged 1 commit intocodeigniter4:developfrom rnazali:patch-1
TestResponse.assertNotOk()#8585kenjis merged 1 commit intocodeigniter4:developfrom
rnazali:patch-1
Conversation
The docstring for said method seems to be copied from `assertOK()` and left unchanged.
ddevsr
approved these changes
Feb 26, 2024
kenjis
changed the title
TestResponse.assertNotOk()TestResponse.assertNotOk()
kenjis
approved these changes
Feb 26, 2024
Member
|
@rahmatnazali Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The docstring for
TestResponse.assertNotOk()method seems to be copied fromassertOK()and left unchanged.In this PR I'm proposing small change to fix it.
Checklist:
Component(s) with PHPDoc blocks, only if necessary or adds value(no code added/changed)Unit testing, with >80% coverage(no code added/changed)User guide updated(no code added/changed)