Skip to content

feat: improve Redis Session#8578

Merged
kenjis merged 5 commits intocodeigniter4:4.5from
kenjis:improve-redis-session
Mar 25, 2024
Merged

feat: improve Redis Session#8578
kenjis merged 5 commits intocodeigniter4:4.5from
kenjis:improve-redis-session

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Feb 24, 2024

Description

  • add config for lock timeout
  • support Redis ACL (username/password)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Feb 24, 2024
@kenjis kenjis force-pushed the improve-redis-session branch 2 times, most recently from 1f5dc0d to 2974737 Compare February 24, 2024 04:54
@kenjis kenjis changed the title feat: Improve Redis Session feat: improve Redis Session Feb 25, 2024
@github-actions github-actions bot added the stale Pull requests with conflicts label Feb 26, 2024
@github-actions

This comment was marked as outdated.

 Conflicts:
	system/Session/Handlers/RedisHandler.php
like `tcp://localhost:6379?auth[user]=redis-admin&auth[pass]=admin-password`
and Unix domain socket like `unix:///tmp/redis.sock`.

 Conflicts:
	system/Session/Handlers/RedisHandler.php
@kenjis kenjis force-pushed the improve-redis-session branch from 2974737 to 615aa18 Compare February 26, 2024 01:53
@kenjis kenjis removed the stale Pull requests with conflicts label Feb 26, 2024
@kenjis kenjis merged commit 879479c into codeigniter4:4.5 Mar 25, 2024
@kenjis kenjis deleted the improve-redis-session branch March 25, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that improve existing functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants