feat: add Boot class and refactor index.php/spark/CodeIgniter::initialize()#8558
Closed
kenjis wants to merge 36 commits intocodeigniter4:4.5from
Closed
feat: add Boot class and refactor index.php/spark/CodeIgniter::initialize()#8558kenjis wants to merge 36 commits intocodeigniter4:4.5from
kenjis wants to merge 36 commits intocodeigniter4:4.5from
Conversation
kenjis
force-pushed
the
move-kint-loader
branch
from
98740ea to
88d4e6e
Compare
kenjis
force-pushed
the
move-kint-loader
branch
6 times, most recently
from
42b1d95 to
6bab1e1
Compare
kenjis
changed the title
kenjis
force-pushed
the
move-kint-loader
branch
5 times, most recently
from
72138c7 to
0392a18
Compare
kenjis
added
breaking change
kenjis
added
the
bug
Member
Author
|
I found that
(develop *$=)$ ./spark
CodeIgniter v4.4.5 Command Line Tool - Server Time: 2024-02-19 10:33:30 UTC+00:00
[ParseError]
syntax error, unexpected token "protected", expecting "," or ";"
at SYSTEMPATH/Commands/ListCommands.php:38
Backtrace:
1 SYSTEMPATH/Autoloader/Autoloader.php:253
CodeIgniter\Autoloader\Autoloader()->includeFile('/Users/kenji/work/codeigniter/official/CodeIgniter4/vendor/composer/../../system/Commands/ListCommands.php')
2 [internal function]
CodeIgniter\Autoloader\Autoloader()->loadClassmap('CodeIgniter\\Commands\\ListCommands')
3 SYSTEMPATH/CLI/Commands.php:105
class_exists('CodeIgniter\\Commands\\ListCommands')
4 SYSTEMPATH/CLI/Commands.php:46
CodeIgniter\CLI\Commands()->discoverCommands()
5 SYSTEMPATH/Config/Services.php:174
CodeIgniter\CLI\Commands()->__construct()
6 SYSTEMPATH/Config/BaseService.php:258
CodeIgniter\Config\Services::commands(false)
7 SYSTEMPATH/Config/BaseService.php:199
CodeIgniter\Config\BaseService::__callStatic('commands', [...])
8 SYSTEMPATH/Config/Services.php:171
CodeIgniter\Config\BaseService::getSharedInstance('commands')
9 SYSTEMPATH/Config/BaseService.php:258
CodeIgniter\Config\Services::commands()
10 SYSTEMPATH/CLI/Console.php:41
CodeIgniter\Config\BaseService::__callStatic('commands', [])
11 ROOTPATH/spark:102
CodeIgniter\CLI\Console()->run()
(develop *$=)$ ./spark
CodeIgniter v4.4.5 Command Line Tool - Server Time: 2024-02-19 10:33:42 UTC+00:00
[ParseError]
syntax error, unexpected token "protected", expecting "," or ";"
at SYSTEMPATH/Commands/ListCommands.php:38
(develop *$=)$ |
kenjis
force-pushed
the
move-kint-loader
branch
4 times, most recently
from
97e6cb0 to
20c827f
Compare
kenjis
force-pushed
the
move-kint-loader
branch
from
8827884 to
c59b981
Compare
kenjis
changed the title
kenjis
force-pushed
the
move-kint-loader
branch
from
c59b981 to
50d8339
Compare
and move code from index.php to Boot class.
This setting is for Web Page Caching, not for Cache service.
The Cache Config class that extends BaseConfig is very slow to instantiate.. See codeigniter4#8558 (comment)
kenjis
added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Mar 4, 2024
The Cache Config class that extends BaseConfig is very slow to instantiate.. See codeigniter4#8558 (comment)
Member
Author
5 tasks
kenjis
added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Mar 7, 2024
The Cache Config class that extends BaseConfig is very slow to instantiate.. See codeigniter4#8558 (comment)
kenjis
added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Mar 10, 2024
The Cache Config class that extends BaseConfig is very slow to instantiate.. See codeigniter4#8558 (comment)
kenjis
added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Mar 18, 2024
The Cache Config class that extends BaseConfig is very slow to instantiate.. See codeigniter4#8558 (comment)
kenjis
added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Mar 26, 2024
The Cache Config class that extends BaseConfig is very slow to instantiate.. See codeigniter4#8558 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #7824
CodeIgniter::initializeKint()registers an autoloader. So it is better to be in Autoloader.Bootclass, thenindex.php,spark, andTest/bootstrap.phpuse itConfig\Optimize::$configCacheEnabledConfig\Optimize::$locatorCacheEnabledsystem/bootstrap.phpChecklist: