Skip to content

docs: restore goals.rst from 3.0 user guide#8557

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:docs-concepts-goals.rst
Jun 12, 2024
Merged

docs: restore goals.rst from 3.0 user guide#8557
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:docs-concepts-goals.rst

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Feb 18, 2024

Description
I don't know why this "Design and Architectural Goals" was removed in 4.0 user guide.
But I would like to restore it.

Basically, this goal is still valid today. If there are any changes that should be made,
please comment.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Feb 18, 2024
Copy link
Copy Markdown

@TimexPeachtree TimexPeachtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yess this looks back to good

@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Mar 5, 2024

Related #8201

Copy link
Copy Markdown
Contributor

@neznaika0 neznaika0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is not critical, but has been hanging in PR for a long time

@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Jun 7, 2024

@MGatner @lonnieezell May I merge this?

Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this. I came in for a critical read and found no real issues - which makes me think this document might be too abstract or general.

@kenjis kenjis merged commit cf0e87d into codeigniter4:develop Jun 12, 2024
@kenjis kenjis deleted the docs-concepts-goals.rst branch June 12, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants