fix: [Validation] exact_length does not pass int values#8088
Merged
kenjis merged 2 commits intocodeigniter4:developfrom Oct 25, 2023
Merged
fix: [Validation] exact_length does not pass int values#8088kenjis merged 2 commits intocodeigniter4:developfrom
kenjis merged 2 commits intocodeigniter4:developfrom
Conversation
ace97aa to
391723b
Compare
MGatner
approved these changes
Oct 25, 2023
Member
MGatner
left a comment
There was a problem hiding this comment.
I agree, good logical change.
michalsn
approved these changes
Oct 25, 2023
Member
Author
|
Thank you for reviews! Guys. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From Slack
exact_lengthin traditional rules passes int valuesexact_lengthin strict rules passes only string values‘required|numeric|exact_length[10]is invalid, and if you pass1234567890, you will get the error "The XXX field must be exactly 10 characters in length."Checklist: