config: remove App\ and Config\ in autoload.psr-4 in app starter composer.json#5824
Merged
kenjis merged 2 commits intocodeigniter4:developfrom Mar 24, 2022
Merged
config: remove App\ and Config\ in autoload.psr-4 in app starter composer.json#5824kenjis merged 2 commits intocodeigniter4:developfrom
kenjis merged 2 commits intocodeigniter4:developfrom
Conversation
…ser.json Revert codeigniter4#3423 Problems: - Cannot change `app` folder name. Because the composer's path overwrite the config in Config\Autoload. - Causes error when defining new namespace under app/. See codeigniter4#5818
kenjis
added
the
bug
samsonasik
approved these changes
Mar 23, 2022
Member
Author
|
@samsonasik Thank you! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revert #3423
Fixes #5818
Why
autoload.psr-4causes problems:appfolder name. Because the composer's path overwrite the config inConfig\Autoload. See https://forum.codeigniter.com/thread-81153.htmlapp/. See Bug: defining new namespace underapp/causesCannot declare class ..., because the name is already in use#5818If there is a user who wants to use Composer autoloader optimization (
dump-autoload -o) forAppnamespace class files, they could add it inautoload.psr-4by themself.Checklist: