[4.2] [Rector] Apply PHP 7.4 Requirement and syntax#5462
Merged
samsonasik merged 11 commits intocodeigniter4:v4.2from Dec 14, 2021
Merged
[4.2] [Rector] Apply PHP 7.4 Requirement and syntax#5462samsonasik merged 11 commits intocodeigniter4:v4.2from
samsonasik merged 11 commits intocodeigniter4:v4.2from
Conversation
samsonasik
changed the title
Member
|
Looking good! |
Member
Author
|
Temporary run rector workflow on php 8.0 only due to error |
Member
Author
|
I temporary ignore phpstan notice on syntax |
system/HTTP/URI.php
Outdated
| return str_replace($match['key'], bin2hex($match['key']), $match[0]); | ||
| }, urldecode($chunk)); | ||
| }, $query); | ||
| $params = array_map(static fn (string $chunk) => preg_replace_callback('/^(?<key>[^&=]+?)(?:\[[^&=]*\])?=(?<value>[^&=]+)/', static fn (array $match) => str_replace($match['key'], bin2hex($match['key']), $match[0]), urldecode($chunk)), $query); |
Member
There was a problem hiding this comment.
Can you break this into many lines?
paulbalandan
approved these changes
Dec 14, 2021
Member
|
Looks good! |
MGatner
approved these changes
Dec 14, 2021
Member
Author
|
I am merging it ;). Thanks @paulbalandan @kenjis @MGatner for the review. |
samsonasik
commented
Dec 14, 2021
| $services->set(SimplifyEmptyArrayCheckRector::class); | ||
| $services->set(TypedPropertyRector::class) | ||
| ->configure([ | ||
| TypedPropertyRector::PRIVATE_PROPERTY_ONLY => true, |
Member
Author
There was a problem hiding this comment.
private property only option will be removed in next rector release rectorphp/rector-src#1496, to have default change:
- change private property
- change protected property for final class.
- don't update public property.
We can retry re-run when on next rector release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@MGatner here the update to php 7.4:
TODO:
Checklist: