add app and app/Config to autoload composer.json for app starter#3423
Conversation
|
I think we should exclude |
|
That change may less happen, also, composer autoload doesn't break codeigniter 4 autoloader, that will be a fallback namespace. |
michalsn
left a comment
There was a problem hiding this comment.
I can't think of any disadvantages of this solution.
|
We cannot change @samsonasik What's the benefit to use composer autoload? |
|
As far as i remember, with prioritize composer autoload when possible, it will got benefit for composer itself (eg: classmap on Probably in case of changing |
|
It's time to abandon the internal autoloader and use only the composer. |
|
@samsonasik Thank you. I'm not sure that composer's autoloader has priority. I'll check. |
|
@iRedds Do you mean the zip installation will be discontinued? |
|
One core tenet of CI has always been the ability to download a zip and not worry about anything. From my experience on the forums since v4 has been released this is still the case for a large chunk of users. We must always remember the broader user-base and CodeIgniter's history. While we don't want to be completely beholden to old ways, we do need to pay attention to the users, and not alienate a broad group of them for no discernible gain. |
|
This could have been avoided if we did not have the |
|
@kenjis Do you need a zip installation? |
|
@iRedds Personally I never use zip installation, but I don't say drop it soon. I see users using Zip who report GitHub issues sometime. |
|
@kenjis Composer.phar and the installed framework can be added to the zip. |
|
No, @samsonasik is correct. |
I don't think it is good idea. |
…ser.json Revert codeigniter4#3423 Problems: - Cannot change `app` folder name. Because the composer's path overwrite the config in Config\Autoload. - Causes error when defining new namespace under app/. See codeigniter4#5818

The starter app is mostly installed via composer create-project. I think it is better to use composer autoload for it.
Checklist: