Fixed ConcurrentModificationException on a map and tweeked some options. by MarcMazas · Pull Request #443 · codehaus-plexus/plexus-compiler

MarcMazas · 2025-07-09T09:32:27Z

No description provided.

Signed-off-by: mmazas <[email protected]>

olamy · 2025-07-12T09:16:47Z

Do you have a stack trace of the ConcurrentModificationException?

MarcMazas · 2025-07-12T12:26:56Z

I had one, but did not record it, pointing on the second call to it.next(), denoting the map change due to the put() on it; the proposed and tested fix is to use an additional map ca2. Le sam. 12 juil. 2025 à 11:17, Olivier Lamy ***@***.***> a écrit :

…

*olamy* left a comment (codehaus-plexus/plexus-compiler#443) <#443 (comment)> Do you have a stack trace of the ConcurrentModificationException? — Reply to this email directly, view it on GitHub <#443 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFQZRCZPKINQOZYDFJBRWVT3IDHBLAVCNFSM6AAAAACBDR3KUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANRUHE4DANBTGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Signed-off-by: mmazas <[email protected]>

MarcMazas · 2025-07-16T09:10:18Z

I added a commit to fix erroneous excludes management.

MarcMazas · 2025-07-16T14:39:27Z

Do you have a stack trace of the ConcurrentModificationException?

You should get one easily with:

                  <compilerArgs>
                    <arg>-nologo:true</arg>
                    <arg>-nowarn:0414</arg>
                    <arg>-utf8output:true</arg>
                    <arg>-target:exe</arg>
                    <arg>-out:${project.artifactId}.exe</arg>
                  </compilerArgs>

MarcMazas · 2025-12-29T16:16:48Z

This PR seems not still merged...
With version 2.16.1:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (csharp-compile) on project jtb-javacc-goal: Execution csharp-compile of goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile failed. ConcurrentModificationException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (csharp-compile) on project jtb-javacc-goal: Execution csharp-compile of goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile failed.
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:333)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:903)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:280)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:203)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution csharp-compile of goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile failed.
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:133)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:903)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:280)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:203)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)
Caused by: java.util.ConcurrentModificationException
at java.util.LinkedHashMap$LinkedHashIterator.nextNode (LinkedHashMap.java:719)
at java.util.LinkedHashMap$LinkedKeyIterator.next (LinkedHashMap.java:742)
at org.codehaus.plexus.compiler.csharp.CSharpCompiler.getCompilerArguments (CSharpCompiler.java:147)
at org.codehaus.plexus.compiler.csharp.CSharpCompiler.buildCompilerArguments (CSharpCompiler.java:440)
at org.codehaus.plexus.compiler.csharp.CSharpCompiler.createCommandLine (CSharpCompiler.java:130)
at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute (AbstractCompilerMojo.java:1083)
at org.apache.maven.plugin.compiler.CompilerMojo.execute (CompilerMojo.java:225)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:903)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:280)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:203)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)
[ERROR]
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[DEBUG] Shutting down adapter factory; available factories [file-lock, rwlock-local, semaphore-local, noop]; available name mappers [discriminating, file-gav, file-hgav, file-static, gav, static]
[DEBUG] Shutting down 'file-lock' factory
[DEBUG] Shutting down 'rwlock-local' factory
[DEBUG] Shutting down 'semaphore-local' factory
[DEBUG] Shutting down 'noop' factory

slachiewicz · 2026-01-01T14:53:14Z

@MarcMazas based on Your's discovery and work - i'm proposing to fix it bit differently #466

mmazas and others added 4 commits April 11, 2025 11:18

Added 3 compiler options.

c0b88ba

Signed-off-by: mmazas <[email protected]>

Merge branch 'codehaus-plexus:master' into master

1d16781

Fixed ConcurrentModificationException on a map and tweeked some options.

4d538e2

Signed-off-by: mmazas <[email protected]>

Merge branch 'master' of [email protected]:MarcMazas/plexus-compiler.git

cfa2f13

Fixed wrong excludes management.

1ccef57

Signed-off-by: mmazas <[email protected]>

pzygielo reviewed Jul 16, 2025

View reviewed changes

Comment thread ...plexus-compiler-csharp/src/main/java/org/codehaus/plexus/compiler/csharp/CSharpCompiler.java

pzygielo mentioned this pull request Jul 16, 2025

Fixed wrong excludes management #444

Merged

slachiewicz requested a review from Copilot October 5, 2025 17:40

This comment was marked as resolved.

Sign in to view

slachiewicz marked this pull request as draft November 3, 2025 17:35

slachiewicz added the bug label Jan 1, 2026

slachiewicz closed this Jan 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed ConcurrentModificationException on a map and tweeked some options.#443

Fixed ConcurrentModificationException on a map and tweeked some options.#443
MarcMazas wants to merge 5 commits intocodehaus-plexus:masterfrom
MarcMazas:master

MarcMazas commented Jul 9, 2025

Uh oh!

olamy commented Jul 12, 2025

Uh oh!

MarcMazas commented Jul 12, 2025 via email

Uh oh!

MarcMazas commented Jul 16, 2025

Uh oh!

Uh oh!

MarcMazas commented Jul 16, 2025

Uh oh!

This comment was marked as resolved.

Uh oh!

MarcMazas commented Dec 29, 2025 •

edited

Loading

Uh oh!

slachiewicz commented Jan 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

MarcMazas commented Jul 9, 2025

Uh oh!

olamy commented Jul 12, 2025

Uh oh!

MarcMazas commented Jul 12, 2025 via email

Uh oh!

MarcMazas commented Jul 16, 2025

Uh oh!

Uh oh!

MarcMazas commented Jul 16, 2025

Uh oh!

This comment was marked as resolved.

Uh oh!

MarcMazas commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slachiewicz commented Jan 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MarcMazas commented Dec 29, 2025 •

edited

Loading