This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Remove 'x-amz-acl': 'public-read' header#178
Merged
Conversation
Codecov recently did some fundamental storage changes on its backend in an effort to greatly improve the reliability of our underlying storage systems. As a result the `X-Amz-Acl: public-read` header is no longer needed, and may result in 400 errors if used. You can see a similar fix in codecov-python that removes that header here: https://github.com/codecov/codecov-python/pull/253/files
This was referenced Mar 10, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codecov recently did some fundamental storage changes on its backend in an effort to greatly improve the reliability of our underlying storage systems. As a result the
X-Amz-Acl: public-readheader is no longer needed, and may result in 400 errors if used.You can see a similar fix in codecov-python that removes that header here: https://github.com/codecov/codecov-python/pull/253/files