This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Verify source version before parsing PR#172
Merged
eddiemoore merged 1 commit intocodecov:masterfrom Mar 9, 2020
Merged
Conversation
Non-PR hooks can trigger builds in which the CODEBUILD_SOURCE_VERSION would be populated as the commit SHA. Our current logic dictates that that commit SHA would be passed onto CodeCov as the PR number, which would always be an invalid value (must be a number, true, or falsy). This updates the logic so that it will ensure that the environment variable being checked actually matches the "pr/" pattern before trying to use it. If it does not, it will return undefined.
RoboCafaz
force-pushed
the
bugfix/codebuild-pr-parser
branch
from
f268a0b to
ef348ec
Compare
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 90.16% 90.22% +0.05%
==========================================
Files 23 23
Lines 356 358 +2
Branches 85 87 +2
==========================================
+ Hits 321 323 +2
Misses 35 35 Continue to review full report at Codecov.
|
|
Wonder if this also resolves #153. Pinging @eddiemoore for his attention. |
eddiemoore
approved these changes
Mar 9, 2020
Contributor
Author
|
@eddiemoore Any timelines for a new version release? |
This was referenced Mar 10, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #171
Non-PR hooks can trigger builds in which the CODEBUILD_SOURCE_VERSION
would be populated as the commit SHA. Our current logic dictates that
that commit SHA would be passed onto CodeCov as the PR number, which
would always be an invalid value.
This updates the logic so that it will ensure that the environment
variable being checked actually matches the "pr/" pattern before trying
to use it. If it does not, it will return undefined.