This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Handle builds triggered by AWS SDK.#149
Merged
eddiemoore merged 2 commits intocodecov:masterfrom Jan 31, 2020
aiell0:master
Merged
Handle builds triggered by AWS SDK.#149eddiemoore merged 2 commits intocodecov:masterfrom aiell0:master
eddiemoore merged 2 commits intocodecov:masterfrom
aiell0:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 89.8% 90.11% +0.31%
==========================================
Files 23 23
Lines 353 354 +1
Branches 85 85
==========================================
+ Hits 317 319 +2
+ Misses 36 35 -1
Continue to review full report at Codecov.
|
Contributor
Author
|
@eddiemoore Can we get this merged? |
eddiemoore
approved these changes
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Codebuild can be triggered by webhooks, or by resources inside the AWS cloud environment (such as lambda) via the AWS SDK. Upon triggering builds with the SDK inside Lambda, I was receiving the error documented inside #148. The intent of this PR is to resolve the issue.
Changelog
lib/services/codebuild.jstest/services/codebuild.test.js