fix: log info if a file shows up as a directory by thomasrockhu-codecov · Pull Request #430 · codecov/codecov-cli

thomasrockhu-codecov · 2024-05-05T16:12:09Z

git ls-files will pull submodules as files, this change just logs that a file shows up as such a directory and continues on

github-actions · 2024-05-05T16:12:43Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-05T16:12:44Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-05T16:12:47Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-05T16:12:52Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

codecov · 2024-05-05T16:12:54Z

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2664 tests with 4 failed, 2660 passed and 0 skipped.

View the full list of failed tests

Test Description	Failure message
Testsuite: pytest Test name: api.temp.calculator.test_calculator::test_divide Envs: - python3.8	def test_divide(): > assert Calculator.divide(1, 2) == 0.5 E assert 1.0 == 0.5 E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2) E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide .../temp/calculator/test_calculator.py:30: AssertionError
Testsuite: pytest Test name: api.temp.calculator.test_calculator::test_divide Envs: - python3.9	def test_divide(): > assert Calculator.divide(1, 2) == 0.5 E assert 1.0 == 0.5 E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2) E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide .../temp/calculator/test_calculator.py:30: AssertionError
Testsuite: pytest Test name: api.temp.calculator.test_calculator::test_divide Envs: - python3.10	def test_divide(): > assert Calculator.divide(1, 2) == 0.5 E assert 1.0 == 0.5 E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2) E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide .../temp/calculator/test_calculator.py:30: AssertionError
Testsuite: pytest Test name: api.temp.calculator.test_calculator::test_divide Envs: - python3.11	def test_divide(): > assert Calculator.divide(1, 2) == 0.5 E assert 1.0 == 0.5 E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2) E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide .../temp/calculator/test_calculator.py:30: AssertionError

thomasrockhu-codecov · 2024-05-05T16:21:23Z

                    reason=err.reason,
                ),
            )
+        except IsADirectoryError as err:


This is the relevant section

github-actions · 2024-05-05T16:21:30Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-05T16:21:31Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-05T16:21:33Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-05T16:21:38Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T09:12:47Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T09:12:47Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T09:12:47Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T09:12:50Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T09:22:11Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T09:22:13Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T09:22:21Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

github-actions · 2024-05-06T09:22:52Z

❌ Failed Test Results:

Completed 666 tests with 1 failed, 665 passed and 0 skipped.

View the full list of failed tests

Test Description

Failure message

Testsuite:
api.temp.calculator.test_calculator::test_divide

Test name:
pytest

def
                test_divide():
                &gt; assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = &lt;function Calculator.divide at 0x104c9eb90&gt;(1, 2)
                E + where &lt;function Calculator.divide at 0x104c9eb90&gt; = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

giovanni-guidini

Wouldn't hurt to have a test for it, but LGTM

fix: log info if a file shows up as a directory

368db65

thomasrockhu-codecov commented May 5, 2024

View reviewed changes

fix: black

f01b2e7

thomasrockhu-codecov force-pushed the th/isadirectory-error branch from 305474c to f01b2e7 Compare May 6, 2024 09:12

fix: lint

e155cac

giovanni-guidini approved these changes May 7, 2024

View reviewed changes

thomasrockhu-codecov merged commit e4b6e1c into main May 7, 2024

thomasrockhu-codecov deleted the th/isadirectory-error branch May 7, 2024 14:35

Conversation

thomasrockhu-codecov commented May 5, 2024

Uh oh!

github-actions Bot commented May 5, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 5, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 5, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 5, 2024

❌ Failed Test Results:

Uh oh!

codecov Bot commented May 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Failed Test Results:

Uh oh!

thomasrockhu-codecov May 5, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 5, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 5, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 5, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 5, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

github-actions Bot commented May 6, 2024

❌ Failed Test Results:

Uh oh!

giovanni-guidini left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented May 5, 2024 •

edited

Loading