feat: add network prefix and filter options#406
Merged
thomasrockhu-codecov merged 5 commits intomainfrom Apr 8, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
+ Coverage 95.76% 96.06% +0.29%
==========================================
Files 81 81
Lines 2925 2843 -82
==========================================
- Hits 2801 2731 -70
+ Misses 124 112 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
giovanni-guidini
previously approved these changes
Apr 5, 2024
Contributor
Author
|
Updated PTAL @joseph-sentry |
joseph-sentry
approved these changes
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #405
This adds the
--network-prefixand--network-filterarguments that existed in the uploader (and the bash uploader).This PR does the following:
--network-prefixand--network-filterargumentsNetworkFinder.find_filesand execute on them--network-root-folderto theNetworkFinder.find_filesfunction also_produce_file_fixes_for_networkto_produce_file_fixesas file fixes are not relevant to the network. This helps prevent file fixes from blowing up since the network filepaths are changing