This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Add send email task to task service#152
Merged
joseph-sentry merged 2 commits intomainfrom Oct 10, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
=======================================
- Coverage 95.47 95.46 -0.01
=======================================
Files 714 714
Lines 15312 15314 +2
=======================================
+ Hits 14618 14619 +1
- Misses 694 695 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 95.56% 95.56% -0.01%
==========================================
Files 599 599
Lines 14911 14913 +2
==========================================
+ Hits 14250 14251 +1
- Misses 661 662 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
scott-codecov
approved these changes
Sep 25, 2023
| ), | ||
| ).apply_async() | ||
|
|
||
| def send_email(self, ownerid, template_name, from_addr, subject, **kwargs): |
Contributor
There was a problem hiding this comment.
Some type annotations might be nice here
joseph-sentry
force-pushed
the
joseph/send-email
branch
from
67f938d to
95b5cca
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 95.56% 95.56% -0.01%
==========================================
Files 599 599
Lines 14911 14913 +2
==========================================
+ Hits 14250 14251 +1
- Misses 661 662 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: joseph-sentry <[email protected]>
Signed-off-by: joseph-sentry <[email protected]>
joseph-sentry
force-pushed
the
joseph/send-email
branch
from
99f9910 to
7bdbbf4
Compare
RulaKhaled
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Add send email task to task service * Add type annotations to send_email function args Signed-off-by: joseph-sentry <[email protected]>
RulaKhaled
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Add send email task to task service * Add type annotations to send_email function args Signed-off-by: joseph-sentry <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
The API should be able to enqueue a task to send an email to a user.
Links to relevant tickets
Fixes: codecov/engineering-team#158
What does this PR do?
entry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.