Migrate to package:web #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
commented
Dec 7, 2023
Comment on lines
-7
to
+8
| sdk: '>=2.12.1 <3.0.0' | ||
| flutter: ">=2.5.0" | ||
| sdk: ^3.2.0 | ||
| flutter: ^3.16.0 |
Contributor
Author
There was a problem hiding this comment.
Hm, the android version doesn't seem to like this flutter update...
$ flutter run -d emu
Launching lib/main.dart on Android SDK built for x86 in debug mode...
package identifier or launch activity not found.
Please check /work/ditman/codebird-flutter_app_icons/example/android/app/src/main/AndroidManifest.xml for errors.
No application found for TargetPlatform.android_x86.
Is your project missing an android/app/src/main/AndroidManifest.xml?
Consider running "flutter create ." to create one.Would you be willing to update this package to a more recent version of Flutter @codebird?
Owner
There was a problem hiding this comment.
Hello @ditman,
Thanks for the PR.
Will check it out, and see if I can fix on android.
Yes I surely would like to keep it working with the most recent version of flutter, and keep it going... Time is always the issue.
Owner
There was a problem hiding this comment.
The issue is with DONT_KILL_APP flag, android doesn't like it anymore. Going to merge your pull request as it enhances the package... Will try to figure something out for Android.
Contributor
Author
|
Thanks for the super fast merge! 🙏 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
package:web. This allows this package to be used by apps that want to be compiled to WASM.This is what the example web app looks like now:
Thanks for this package @codebird!