fix(sisyphus-task): guard client.session.get and update sync mode tests #754
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add guard clause to check if client.session.get exists before calling - Update 4 sync mode tests to properly mock session.get - Fixes test failures from PR #731 directory inheritance feature
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #731 added
client.session.getfor directory inheritance but didn't update tests. The.catch()pattern only handles Promise rejections, not synchronous TypeError when the method is undefined.Solution
client.session.getexists before calling (defensive coding for older clients)getmock to 4 sync mode tests so they properly test the real code pathChanges
src/tools/sisyphus-task/tools.ts- Guard clause forclient.session.getsrc/tools/sisyphus-task/tools.test.ts- Addedgetmock to 4 testsVerification
All 27 tests pass.
Summary by cubic
Fixes a crash in sync mode by guarding client.session.get and keeps tests aligned with the directory inheritance behavior. This restores compatibility with older clients that don’t implement session.get.
Written for commit 444b7ce. Summary will update on new commits.