fix(test): update sisyphus-orchestrator test assertion #728
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gent response The implementation preserves original subagent responses for debugging failed tasks. Updated test assertion from .not.toContain() to .toContain() to match this behavior.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes failing test:
should transform output when caller is orchestrator-sisyphus with boulder stateProblem
The implementation was updated to preserve original subagent responses for debugging purposes, but the test still expected the response to be stripped.
Solution
Updated the test assertion from
.not.toContain()to.toContain()to match the intended behavior where subagent responses are preserved under "Subagent Response:" section.Verification
Summary by cubic
Updated the sisyphus-orchestrator test to expect preserved subagent output. This fixes the failing assertion and aligns the test with current behavior.
Written for commit d1ffecd. Summary will update on new commits.