fix(glob): default hidden=true and follow=true to align with OpenCode #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
kdcokenny
force-pushed
the
fix/631-glob-hidden-directories
branch
from
4ef1466 to
862c99d
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files
Confidence score: 3/5
- PowerShell backend currently passes
-FollowSymlink, which Windows PowerShell 5.1 does not support, so glob runs exit with code 1 and silently fail for those users. - This regression directly affects Windows users and is likely to surface immediately when traversing symlinks, making the merge moderately risky.
- Pay close attention to
src/tools/glob/cli.ts– ensure the PowerShell invocation handles unsupported flags or surfaces errors instead of ignoring exit codes.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/tools/glob/cli.ts">
<violation number="1" location="src/tools/glob/cli.ts:37">
P2: PowerShell backend uses `-FollowSymlink`, which is unsupported in Windows PowerShell 5.1, causing silent failures (exit code 1 ignored) on Windows.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Add follow?: boolean option to GlobOptions interface - Change buildRgArgs to use !== false pattern for hidden and follow flags - Change buildFindArgs to use === false pattern, add -L for symlinks - Change buildPowerShellCommand to use !== false pattern for hidden - Remove -FollowSymlink from PowerShell (unsupported in PS 5.1) - Export build functions for testing - Add comprehensive BDD-style tests (18 tests, 21 assertions) Note: Symlink following via -FollowSymlink is not supported in Windows PowerShell 5.1. OpenCode auto-downloads ripgrep which handles symlinks via --follow flag. PowerShell fallback is a safety net that rarely triggers. Fixes code-yeongyu#631
kdcokenny
force-pushed
the
fix/631-glob-hidden-directories
branch
from
862c99d to
01b01f5
Compare
kdcokenny
added a commit
that referenced
this pull request
Jan 13, 2026
…#720) - Add follow?: boolean option to GlobOptions interface - Change buildRgArgs to use !== false pattern for hidden and follow flags - Change buildFindArgs to use === false pattern, add -L for symlinks - Change buildPowerShellCommand to use !== false pattern for hidden - Remove -FollowSymlink from PowerShell (unsupported in PS 5.1) - Export build functions for testing - Add comprehensive BDD-style tests (18 tests, 21 assertions) Note: Symlink following via -FollowSymlink is not supported in Windows PowerShell 5.1. OpenCode auto-downloads ripgrep which handles symlinks via --follow flag. PowerShell fallback is a safety net that rarely triggers. Fixes #631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #631 - Glob tool now includes hidden files and follows symlinks by default, aligning with OpenCode's internal behavior.
Changes
follow?: booleanoption to GlobOptions interfacebuildRgArgsto use!== falsepattern for--hiddenand--followflagsbuildFindArgsto use=== falsepattern, add-Lfor symlink followingbuildPowerShellCommandto use!== falsepattern, add-FollowSymlinkBreaking Change
Glob tool now defaults to:
hidden: true- includes hidden files/directories (e.g.,.sisyphus/)follow: true- follows symlinksUsers can opt-out with explicit
hidden: falseorfollow: false.OpenCode Alignment
This matches OpenCode's internal ripgrep usage:
Testing