fix(skill-loader): implement eager loading for skills #709
+12
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
- Extract body during initial parseFrontmatter call - Rename lazyContent → eagerLoader with rationale comment - Eliminates redundant file read and race condition
Collaborator
|
thx for the contribution! |
kdcokenny
pushed a commit
that referenced
this pull request
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where skills loaded from
~/.claude/skills(and other directories processed byopencode-skill-loader) would return empty text when invoked as slash commands.Problem
The
opencode-skill-loaderwas initializingCommandDefinition.templateas an empty string ("") and relying onlazyContent.load()to populate it. However, the OpenCode command system likely accesses thetemplateproperty directly without triggering the lazy loader, resulting in empty output.Solution
Modified
src/features/opencode-skill-loader/loader.tsto implement eager loading, similar to howclaude-code-plugin-loaderworks:bodyfromparseFrontmatterimmediately.<skill-instruction>wrapper.definition.template.lazyContentto return the pre-loaded content (preserving interface compatibility but removing the double file read).Verification
bun run typecheckpassedbun run buildpassed~/.claude/skills.Summary by cubic
Fixes empty output from skill slash commands by eagerly loading skill templates in opencode-skill-loader. Aligns behavior with claude-code-plugin-loader and removes unnecessary file reads.
Written for commit 79bd75b. Summary will update on new commits.