fix: LSP tools Windows compatibility - use pathToFileURL for proper URI generation #689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix LSP tools failing on Windows with "unresolvable URI" error.
Fixes #684
Changes
1.
src/tools/lsp/client.tsUse
pathToFileURL()fromnode:urlinstead of string template for file URIs:Why: On Windows,
file://${path}generates invalid URIs likefile://E:\pathinstead offile:///E:/path.2.
src/tools/lsp/utils.tsFix
findWorkspaceRoot()loop condition:Why: On Windows, the root is
C:\not/, so the original condition never terminates properly.Testing
Tested on Windows 11 with clangd 21.1.8:
lsp_hover- workslsp_document_symbols- workslsp_goto_definition- workslsp_find_references- workslsp_prepare_rename- workslsp_workspace_symbols- workslsp_diagnostics- workslsp_code_actions- works