feat(config): add model variant support #677

jkoelker · 2026-01-11T00:04:07Z

Allow optional model variant config for agents and categories. Propagate category variants into task model payloads so category-driven runs inherit provider-specific variants.

Closes: #647

Summary by cubic

Adds optional model variant support to agents and categories. Variants inherit from categories and flow into task model payloads and chat messages, enabling provider-specific tiers (Linear 647).

New Features
- Config/schema: add optional variant to AgentOverrideConfig and CategoryConfig; JSON schema updated.
- Agent build: agents with a category inherit its variant; createBuiltinAgents accepts user categories.
- Background tasks: model payload now includes variant; Sisyphus task passes category variant when used.
- Chat pipeline: first-message variant gate applies agent/category variant on session start; applyAgentVariant sets variant if message has none; keyword detector won’t overwrite an existing variant.
- Tests added for schema, agent building, keyword hook, and Sisyphus task.

^{Written for commit 2b8853c. Summary will update on new commits.}

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

cubic-dev-ai

No issues found across 16 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

jkoelker · 2026-01-11T00:55:59Z

Fixed variant not being set to config value when cached in the model state. This only takes effect on new sessions, so if you change the variant with ctrl+t and then resume the session, it stays whatever was set.

imarshallwidjaja · 2026-01-11T03:26:45Z

I've been testing this and i'm finding it to not be working properly. Do you have a sample oh-my-opencode.json config i can use to test? I've been using:

{
  "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json",
  "auto_update": false,
  "google_auth": false,
  "categories": {
    "visual-engineering": {
      "model": "google/antigravity-gemini-3-pro",
      "variant": "high",
      "temperature": 0.7
    },
    "ultrabrain": {
      "model": "openai/gpt-5.2",
      "variant": "xhigh",
      "temperature": 0.1
    },
    "artistry": {
      "model": "google/antigravity-gemini-3-pro",
      "variant": "high",
      "temperature": 0.9
    },
    "quick": {
      "model": "google/antigravity-gemini-3-flash",
      "variant": "low",
      "temperature": 0.3
    },
    "most-capable": {
      "model": "openai/gpt-5.2",
      "variant": "high",
      "temperature": 0.3
    },
    "writing": {
      "model": "google/antigravity-gemini-3-flash",
      "variant": "high",
      "temperature": 0.5
    },
    "general": {
      "model": "google/antigravity-claude-opus-4-5-thinking",
      "variant": "medium",
      "temperature": 0.3
    }
  },
  "agents": {
    "Sisyphus": {
      "category": "general"
    },
    "Sisyphus-Junior": {
      "category": "general"
    },
    "oracle": {
      "category": "most-capable"
    },
    "librarian": {
      "category": "writing"
    },
    "explore": {
      "category": "quick"
    },
    "frontend-ui-ux-engineer": {
      "category": "visual-engineering"
    },
    "document-writer": {
      "category": "writing"
    },
    "multimodal-looker": {
      "category": "visual-engineering"
    },
    "orchestrator-sisyphus": {
      "category": "general"
    },
    "Prometheus (Planner)": {
      "category": "most-capable"
    },
    "Metis (Plan Consultant)": {
      "category": "most-capable"
    },
    "Momus (Plan Reviewer)": {
      "category": "ultrabrain"
    }
  }
}

And finding some issues:

Category inheritance wasn’t applied when the category came from agent overrides. Builtin agents only inherited category defaults when the agent definition itself had category, not when the user set agents.{name}.category.
- Fix validated: treat agents.{name}.category as the source of truth and apply category defaults (model/temperature/variant/etc) unless explicitly overridden per-agent.
Special-case agents bypassed category logic entirely e.g. Prometheus (Planner), Sisyphus-Junior
- Fix validated: resolve these agents’ model/settings from agents.{name}.category → categories.{cat} first, then fall back.

Applied some fixes: in this draft PR if you were interested: jkoelker#1

imarshallwidjaja · 2026-01-11T03:27:35Z

Lol just noticed you probably fixed it 4 mins ago. will test again, feel free to ignore me if so.

jkoelker · 2026-01-11T03:31:51Z

@imarshallwidjaja the categories vs agents config is very brittle at the moment, i would reccomend setting the model + varient explicitly everywhere.

Allow optional model variant config for agents and categories. Propagate category variants into task model payloads so category-driven runs inherit provider-specific variants. Closes: code-yeongyu#647

imarshallwidjaja

Sorry all just actually confirming that this does 100% work as expected when you properly set the variants in all of the configured agents & categories. Have been using it on a local build merged on top of dev to test (tracking thinking budgets requested using Antigravity Manager).

Copilot

Pull request overview

This PR adds optional model variant support to agents and categories, enabling provider-specific tier configuration (e.g., "low", "high", "max") that propagates through the system from configuration to task execution and chat messages.

Changes:

Added optional variant field to AgentOverrideConfig and CategoryConfig schemas with comprehensive validation tests
Implemented variant inheritance: agents inherit variants from their configured categories, with explicit agent variants taking precedence
Created variant application utilities (resolveAgentVariant, applyAgentVariant) and first-message tracking mechanism to apply variants on session start
Updated background task system and Sisyphus task tool to propagate category variants into model payloads
Modified chat message hooks to apply agent/category variants while respecting pre-existing variants (e.g., from ultrawork keyword)

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`src/config/schema.ts`	Added optional `variant` string field to `AgentOverrideConfigSchema` and `CategoryConfigSchema`
`src/config/schema.test.ts`	Added validation tests for variant field in both agent and category schemas
`assets/oh-my-opencode.schema.json`	Updated JSON schema to include variant field in all agent configurations and category definitions
`src/agents/types.ts`	Added `variant` field to `AgentOverrideConfig` type definition
`src/agents/utils.ts`	Updated `buildAgent` and `createBuiltinAgents` to accept categories config and inherit variant from category if agent doesn't have explicit variant
`src/agents/utils.test.ts`	Added test verifying agents inherit variant from their category configuration
`src/shared/agent-variant.ts`	New utility functions to resolve agent variants from config (with category fallback) and conditionally apply to messages
`src/shared/agent-variant.test.ts`	Comprehensive tests for variant resolution and application logic
`src/shared/first-message-variant.ts`	New gate mechanism to track new sessions and control first-message variant application
`src/shared/first-message-variant.test.ts`	Tests for session tracking and variant gate behavior
`src/shared/index.ts`	Added export for new agent-variant module
`src/features/background-agent/types.ts`	Extended `model` type in `BackgroundTask` and `LaunchInput` to include optional variant field
`src/tools/sisyphus-task/tools.ts`	Updated category model resolution to include variant from category config when launching background tasks
`src/tools/sisyphus-task/tools.test.ts`	Added test verifying variant propagation to background task model payload
`src/hooks/keyword-detector/index.ts`	Modified ultrawork keyword handler to only set variant if not already defined, preserving configured variants
`src/hooks/keyword-detector/index.test.ts`	Added test confirming ultrawork respects pre-existing variants
`src/index.ts`	Integrated variant application in chat.message hook with first-message gate and subsequent-message conditional application, plus session lifecycle tracking
`src/plugin-handlers/config-handler.ts`	Passed user categories config to `createBuiltinAgents` for variant inheritance

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T05:53:09Z

src/index.ts

+      if (firstMessageVariantGate.shouldOverride(input.sessionID)) {
+        const variant = resolveAgentVariant(pluginConfig, input.agent)
+        if (variant !== undefined) {
+          message.variant = variant
+        }
+        firstMessageVariantGate.markApplied(input.sessionID)
+      } else {
+        applyAgentVariant(pluginConfig, input.agent, message)
+      }
+
      await keywordDetector?.["chat.message"]?.(input, output);


The variant application logic may prevent ultrawork keyword from working when agents have configured variants. The order of operations is:

Lines 322-331 apply the agent/category variant to the message (unconditionally on first message, conditionally on subsequent messages)

Line 333 runs keyword detector, which only sets variant to "max" if message.variant === undefined

This means if an agent has a configured variant, the keyword detector will always see it as already set and never apply the "max" variant for ultrawork. While this behavior is tested in keyword-detector/index.test.ts (line 214), consider whether ultrawork should be able to override configured agent variants, as users explicitly typing "ultrawork" might expect it to boost capability regardless of agent configuration.

If ultrawork should be able to override agent variants, consider either:

Checking for ultrawork before applying agent variants, or

Having keyword detector override variants from agent config but not variants from other sources

Suggested change

if (firstMessageVariantGate.shouldOverride(input.sessionID)) {

const variant = resolveAgentVariant(pluginConfig, input.agent)

if (variant !== undefined) {

message.variant = variant

}

firstMessageVariantGate.markApplied(input.sessionID)

} else {

applyAgentVariant(pluginConfig, input.agent, message)

}

await keywordDetector?.["chat.message"]?.(input, output);

// Run keyword detector first so that ultrawork (or other keywords)

// can set message.variant (e.g., to "max") before agent variants

// are applied.

await keywordDetector?.["chat.message"]?.(input, output);

if (firstMessageVariantGate.shouldOverride(input.sessionID)) {

const variant = resolveAgentVariant(pluginConfig, input.agent)

if (variant !== undefined && message.variant === undefined) {

message.variant = variant

}

firstMessageVariantGate.markApplied(input.sessionID)

} else if (message.variant === undefined) {

applyAgentVariant(pluginConfig, input.agent, message)

}

greptile-apps bot reviewed Jan 11, 2026

View reviewed changes

jkoelker force-pushed the fix/add-variant-support branch from 68e1c4d to a3592fa Compare January 11, 2026 00:04

cubic-dev-ai bot reviewed Jan 11, 2026

View reviewed changes

jkoelker force-pushed the fix/add-variant-support branch from a3592fa to f804efc Compare January 11, 2026 00:54

jkoelker force-pushed the fix/add-variant-support branch from f804efc to 33aed90 Compare January 11, 2026 03:21

jkoelker force-pushed the fix/add-variant-support branch from 33aed90 to ac9bf51 Compare January 11, 2026 16:05

qwertystars mentioned this pull request Jan 12, 2026

[Feature]: have predefined ocx profile? #699

Open

6 tasks

jkoelker force-pushed the fix/add-variant-support branch 2 times, most recently from c889467 to 1d42434 Compare January 12, 2026 19:46

feat(config): add model variant support

2b8853c

Allow optional model variant config for agents and categories. Propagate category variants into task model payloads so category-driven runs inherit provider-specific variants. Closes: code-yeongyu#647

jkoelker force-pushed the fix/add-variant-support branch from 1d42434 to 2b8853c Compare January 13, 2026 04:38

imarshallwidjaja approved these changes Jan 13, 2026

View reviewed changes

KNN-07 requested a review from Copilot January 13, 2026 05:48

Copilot started reviewing on behalf of KNN-07 January 13, 2026 05:48 View session

KNN-07 merged commit d2a5f47 into code-yeongyu:dev Jan 13, 2026
6 checks passed

Copilot AI reviewed Jan 13, 2026

View reviewed changes

This was referenced Jan 13, 2026

model selection only has GPT-5.2 Codex, not low/medium/high/xhigh even through opencode.json has it anomalyco/opencode#7593

Closed

[Question]: Sisyphus is doing all the work itself? #694

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(config): add model variant support #677

feat(config): add model variant support #677

Uh oh!

jkoelker commented Jan 11, 2026 •

edited by cubic-dev-ai bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

jkoelker commented Jan 11, 2026

Uh oh!

imarshallwidjaja commented Jan 11, 2026

Uh oh!

imarshallwidjaja commented Jan 11, 2026

Uh oh!

jkoelker commented Jan 11, 2026

Uh oh!

imarshallwidjaja left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(config): add model variant support #677

feat(config): add model variant support #677

Uh oh!

Conversation

jkoelker commented Jan 11, 2026 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

jkoelker commented Jan 11, 2026

Uh oh!

imarshallwidjaja commented Jan 11, 2026

Uh oh!

imarshallwidjaja commented Jan 11, 2026

Uh oh!

jkoelker commented Jan 11, 2026

Uh oh!

imarshallwidjaja left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jkoelker commented Jan 11, 2026 •

edited by cubic-dev-ai bot

Loading