fix(lsp): cleanup orphaned LSP servers on session.deleted #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parallel background agent tasks complete, their LSP servers (for repos cloned to /tmp/) remain running until a 5-minute idle timeout. This causes memory accumulation with heavy parallel Sisyphus usage, potentially leading to OOM crashes. This change adds cleanupTempDirectoryClients() to LSPServerManager (matching the pattern used by SkillMcpManager.disconnectSession()) and calls it on session.deleted events. The cleanup targets idle LSP clients (refCount=0) for temporary directories (/tmp/, /var/folders/) where agent tasks clone repos.
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
Author
|
recheck |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
renekris
pushed a commit
to renekris/oh-my-glm
that referenced
this pull request
Jan 11, 2026
KNN-07
pushed a commit
to KNN-07/oh-my-opencode
that referenced
this pull request
Jan 11, 2026
…yu#676) * fix(lsp): cleanup orphaned LSP servers on session.deleted When parallel background agent tasks complete, their LSP servers (for repos cloned to /tmp/) remain running until a 5-minute idle timeout. This causes memory accumulation with heavy parallel Sisyphus usage, potentially leading to OOM crashes. This change adds cleanupTempDirectoryClients() to LSPServerManager (matching the pattern used by SkillMcpManager.disconnectSession()) and calls it on session.deleted events. The cleanup targets idle LSP clients (refCount=0) for temporary directories (/tmp/, /var/folders/) where agent tasks clone repos. * chore: retrigger CI checks
kdcokenny
pushed a commit
that referenced
this pull request
Jan 13, 2026
kdcokenny
pushed a commit
that referenced
this pull request
Jan 13, 2026
* fix(lsp): cleanup orphaned LSP servers on session.deleted When parallel background agent tasks complete, their LSP servers (for repos cloned to /tmp/) remain running until a 5-minute idle timeout. This causes memory accumulation with heavy parallel Sisyphus usage, potentially leading to OOM crashes. This change adds cleanupTempDirectoryClients() to LSPServerManager (matching the pattern used by SkillMcpManager.disconnectSession()) and calls it on session.deleted events. The cleanup targets idle LSP clients (refCount=0) for temporary directories (/tmp/, /var/folders/) where agent tasks clone repos. * chore: retrigger CI checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When parallel background agent tasks complete, their LSP servers (for repos cloned to
/tmp/) remain running until a 5-minute idle timeout. This causes memory accumulation with heavy parallel Sisyphus usage, potentially leading to OOM crashes.Root cause:
SkillMcpManagerhasdisconnectSession()called onsession.deletedevents, butLSPServerManagerhas no equivalent cleanup mechanism.Solution
Added
cleanupTempDirectoryClients()toLSPServerManager(matching the pattern used bySkillMcpManager.disconnectSession()) and call it onsession.deletedevents.The cleanup targets idle LSP clients (
refCount=0) for temporary directories (/tmp/,/var/folders/) where agent tasks clone repos.Changes
src/tools/lsp/client.ts: AddedcleanupTempDirectoryClients()methodsrc/tools/index.ts: ExportedlspManagersrc/index.ts: Call cleanup onsession.deletedTesting
SkillMcpManager.disconnectSession)Related Issues
Summary by cubic
Clean up idle LSP servers in temp directories when a session is deleted to prevent memory buildup from background agent tasks. Reduces lingering tsserver processes and lowers OOM risk during heavy parallel runs.
Written for commit a8d6cf6. Summary will update on new commits.
I have read the CLA Document and I hereby sign the CLA