fix(git-master): inject user config into skill prompt #656
Conversation
The git_master config (commit_footer, include_co_authored_by) was defined in schema but never consumed. Now the config values are injected into the git-master skill template at load time, making the settings actually work.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8124670251
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const template = skillMap.get(name) | ||
| if (template) { | ||
| resolved.set(name, template) | ||
| if (name === "git-master" && options?.gitMasterConfig) { | ||
| resolved.set(name, injectGitMasterConfig(template, options.gitMasterConfig)) |
There was a problem hiding this comment.
This injection only happens when callers supply gitMasterConfig, but other places that prepend skills (e.g. buildAgent for agents.*.skills in src/agents/utils.ts:66-68) still call resolveMultipleSkills without options. That means a user who sets git_master.include_co_authored_by: false and adds the git-master skill to an agent override will still get the default footer/trailer behavior. Consider threading gitMasterConfig through those callers so the config applies consistently wherever git-master skill content is injected.
Useful? React with 👍 / 👎.
2 participants
Summary
git_masterconfig (commit_footer,include_co_authored_by) actually workProblem
The
git_masterconfig was defined in schema but never consumed. Users settinginclude_co_authored_by: falsehad no effect.Solution
injectGitMasterConfig()inskill-content.tsthat prepends config values as a header to the git-master skill templategitMasterConfigthroughSisyphusTaskToolOptions→resolveMultipleSkills()Files Changed
skill-content.tstools.tsgitMasterConfigindex.tspluginConfig.git_masterto toolSummary by cubic
Fixes git_master so commit_footer and include_co_authored_by settings take effect by injecting user config into the git-master skill prompt at load time. The agent now knows whether to add footers and Co-authored-by lines.
Written for commit 8124670. Summary will update on new commits.