-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(skill-loader): wrap template with skill-instruction tags in sync loader #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…loader The sync loader was setting template to an empty string, while the async loader properly wrapped it with <skill-instruction> and <user-request> tags. This caused inconsistent behavior when skills were loaded through different paths (config-handler vs main plugin). Also removes redundant file re-read in lazyContent.load() by reusing the same wrappedTemplate variable.
|
All contributors have signed the CLA. Thank you! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
|
I have read the CLA Document and I hereby sign the CLA |
…l-instruction tags in sync loader
…l-instruction tags in sync loader
Summary
Fixed the sync skill loader to produce consistently wrapped templates matching the async loader.
Problem
The sync loader was setting template to an empty string, while the async loader properly wrapped it with and tags. This caused skills loaded via config-handler.ts to have empty templates.
Solution
Testing
Summary by cubic
Fixes the sync skill loader so templates are wrapped with and , matching the async loader. Prevents empty templates when loading skills via config-handler.
Bug Fixes
Refactors
Written for commit c965ec6. Summary will update on new commits.