fix: allow orchestrator-sisyphus model override from config #603
+277
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
The orchestrator-sisyphus agent was not respecting model overrides from oh-my-opencode.json because it was missing from: 1. OverridableAgentNameSchema - the Zod enum of overridable agents 2. AgentOverridesSchema - the Zod object that parses the agents config This caused the config override to be silently ignored, and the agent always used the hardcoded default model. Changes: - Add 'orchestrator-sisyphus' to OverridableAgentNameSchema - Add 'orchestrator-sisyphus' to AgentOverridesSchema - Extract DEFAULT_MODEL constant in orchestrator-sisyphus.ts - Add tests for model override behavior Fixes code-yeongyu#601
xLillium
force-pushed
the
fix/orchestrator-sisyphus-model-override
branch
from
40f0d78 to
47953f1
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
Closing this PR as the core fix was already merged by the maintainer in commit ef0220e. The schema changes (adding Our additional contributions (tests, DEFAULT_MODEL constant) are minor and not worth the merge overhead. Thanks @code-yeongyu for the quick fix! 🙏 |
kdcokenny
pushed a commit
that referenced
this pull request
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #601
The
orchestrator-sisyphusagent was not respecting model overrides configured inoh-my-opencode.json. Users configuring a custom model would still see the error: "Agent orchestrator-sisyphus's configured model anthropic/claude-sonnet-4-5 is not valid."Root Cause
The
orchestrator-sisyphusagent was missing from two places in the config schema:OverridableAgentNameSchema- the Zod enum listing which agents can be overriddenAgentOverridesSchema- the Zod object schema that actually parses theagentsconfig sectionWithout being in
AgentOverridesSchema, any config override fororchestrator-sisyphuswas silently ignored during config parsing, and the agent always used the hardcoded default model.Changes
src/config/schema.ts: Added"orchestrator-sisyphus"to bothOverridableAgentNameSchemaandAgentOverridesSchemasrc/agents/orchestrator-sisyphus.ts: ExtractedDEFAULT_MODELconstant for consistency with other agentssrc/agents/utils.test.ts: Added 2 new tests verifying model override behaviorassets/oh-my-opencode.schema.json: Regenerated schemaTesting
src/agents/utils.test.tspass (including 2 new tests)bun run buildbun run typecheck/start-workcommand now uses the configured model overrideVerification Evidence
When running
/start-workwith config override"orchestrator-sisyphus": { "model": "cliproxy/gemini-claude-opus-4-5-thinking" }:The agent now correctly picks up the configured model instead of the hardcoded default.
Summary by cubic
Model overrides for the orchestrator-sisyphus agent now work. The agent reads its model from oh-my-opencode.json and falls back to claude-sonnet-4-5 by default.
Written for commit 47953f1. Summary will update on new commits.