feat: add display_name config option for agents #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Greptile SummaryThis PR adds a Key Changes:
Implementation Quality:
Architecture: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Config as oh-my-opencode.json
participant Index as src/index.ts
participant AgentUtils as agents/utils.ts
participant SisyphusBuilder as sisyphus-prompt-builder.ts
participant BgManager as BackgroundManager
participant CallOmoAgent as call_omo_agent tool
participant BgTask as background_task tool
User->>Config: Configure display_name in agents section
Note over Config: { "agents": { "oracle": { "display_name": "🔮 Oracle" } } }
Index->>Config: Load plugin config
Index->>Index: Extract display names into agentDisplayNames map
Index->>BgManager: new BackgroundManager(ctx, config, agentDisplayNames)
Index->>CallOmoAgent: createCallOmoAgent(ctx, bgManager, agentDisplayNames)
AgentUtils->>AgentUtils: createBuiltinAgents(overrides)
AgentUtils->>AgentUtils: Push to availableAgents with displayName
AgentUtils->>SisyphusBuilder: Pass availableAgents array
SisyphusBuilder->>SisyphusBuilder: buildToolSelectionTable(agents)
Note over SisyphusBuilder: Uses `agent.displayName ?? agent.name`
SisyphusBuilder->>SisyphusBuilder: buildDelegationTable(agents)
Note over SisyphusBuilder: Uses `agent.displayName ?? agent.name`
SisyphusBuilder->>SisyphusBuilder: buildUltraworkAgentSection(agents)
Note over SisyphusBuilder: Uses `agent.displayName ?? agent.name`
User->>CallOmoAgent: Invoke call_omo_agent tool
CallOmoAgent->>BgManager: Launch background task
BgManager->>BgManager: getDisplayName(agent)
CallOmoAgent-->>User: Shows display name in output
BgManager->>BgManager: Task completes
BgManager->>BgManager: notifyParentSession(task)
BgManager->>BgManager: getDisplayName(task.agent)
BgManager-->>User: Toast notification with display name
User->>BgTask: Invoke background_output tool
BgTask->>BgManager: getDisplayName(task.agent)
BgTask-->>User: Shows display name in task status
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
display_nameconfig option for agents, allowing users to customize how agent names appear in output/prompts.Example usage:
{ "agents": { "oracle": { "display_name": "🔮 The All-Knowing One" }, "librarian": { "display_name": "📚 Book Nerd" }, "explore": { "display_name": "🕵️ Detective Pikachu" } } }Changes
display_nametoAgentOverrideConfigSchemain Zod schemadisplayNamefield toAvailableAgentinterfacedisplayName ?? namepatternBackgroundManagerto store and use display namesbackground_taskandcall_omo_agenttools to show display namesWhere Display Names Appear
Verification
Summary by cubic
Adds a display_name config for agents so you can show friendly names across prompts, background tasks, and notifications. If not set, it falls back to the agent’s name.
Written for commit f73dade. Summary will update on new commits.