Repository navigation
fix(agent-config): refresh agent registry on config apply - #4294
Merged
code-yeongyu merged 2 commits intoJun 2, 2026
Merged
code-yeongyu merged 2 commits into
code-yeongyu merged 2 commits into
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <[email protected]>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <[email protected]>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The PR addresses a specific bug by clearing stale agent aliases before re-registering from fresh config, with targeted changes that have no apparent side effects and are covered by regression tests.
Re-trigger cubic
code-yeongyu
force-pushed
the
dev
branch
2 times, most recently
from
May 23, 2026 16:00
eb25d29 to
2bfad49
Compare
Owner
|
[sisyphus-dev] I confirmed #4130 as a real lifecycle/registry bug and am verifying this PR against current dev in an isolated worktree. If the focused tests still pass and mergeability holds, I will merge it under the bug-sweep policy. |
This was referenced Jun 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/connectconfig re-entry cannot leave stale selector aliases behind.Fixes #4130
Verification
lsp_diagnosticsonsrc/features/claude-code-session-state/state.tslsp_diagnosticsonsrc/plugin-handlers/agent-config-handler.tslsp_diagnosticsonsrc/features/claude-code-session-state/state.test.tslsp_diagnosticsonsrc/plugin-handlers/agent-config-handler.test.tsbun test src/features/claude-code-session-state/state.test.ts src/plugin-handlers/agent-config-handler.test.tsbun run typecheckbun run buildgit diff --checkSummary by cubic
Refreshes the agent registry on each config apply so
/connectcan’t leave stale agent aliases behind. Keeps the registry aligned with the freshly rebuilt config and adds regression tests.Written for commit 66fefc3. Summary will update on new commits. Review in cubic