feat(skill-loader): support skills.paths config for plugin skill discovery by ventsislav-georgiev · Pull Request #2840 · code-yeongyu/oh-my-openagent

ventsislav-georgiev · 2026-03-25T23:09:51Z

Summary

Add support for reading skills.paths from opencode.json/opencode.jsonc config files
Plugin authors can ship SKILL.md files in their packages and users point to them via config
Scans project root, .opencode/, and global ~/.config/opencode/ config paths

Problem

OpenCode plugins can register tools via the plugin API, but there's no mechanism for plugins to ship discoverable skills (SKILL.md files). Users had to manually copy or symlink skill files into .opencode/skills/ directories.

OpenCode natively supports skills.paths in config, but oh-my-opencode's skill loader override didn't read this setting, causing a gap where configured skill paths were silently ignored.

Solution

Added readOpenCodeSkillsPaths() that reads skills.paths from opencode config files (checking project root, .opencode/, and global config in precedence order). Wired into both discoverSkills() and discoverAllSkills() with "config" scope priority between opencode and project scopes.

Config example

{
  "skills": {
    "paths": [
      "/absolute/path/to/plugin/skills",
      "relative/path/to/skills",
      "~/home-relative/path"
    ]
  }
}

Changes

New: opencode-config-skills-paths.ts — reads and resolves skills.paths from config
Modified: loader.ts — added discoverConfigPathsSkills(), wired into both discovery flows
New: opencode-config-skills-paths.test.ts — 7 tests covering absolute/relative/JSONC/filtering/integration

Testing

7 new tests pass
97/97 existing skill-loader tests pass (no regressions)
Verified live: plugins' SKILL.md files discovered and available via /skills command

Summary by cubic

Adds support for skills.paths in OpenCode config so plugin SKILL.md directories are auto-discovered and loaded with proper priority. Reads from opencode.json/opencode.jsonc in project and global config to remove the need for manual copies.

New Features
- Reads skills.paths from project root, .opencode/, and ~/.config/opencode (.json and .jsonc).
- Resolves absolute, relative, and ~/ paths; skips missing directories.
- Adds a config scope in discovery priority: opencode-project > opencode > config paths > project > user.
- New discoverConfigPathsSkills() and readOpenCodeSkillsPaths() integrated into discoverSkills and discoverAllSkills.

^{Written for commit 778d826. Summary will update on new commits.}

…overy Read skills.paths from opencode.json/jsonc and scan configured directories for SKILL.md files. This allows plugins to ship their own skills that are discoverable via the standard config mechanism. Scans project root, .opencode/, and global config paths for the setting. Skills from configured paths get 'config' scope priority (between opencode and project scopes).

github-actions · 2026-03-25T23:10:09Z

All contributors have signed the CLA. Thank you! ✅
_{Posted by the CLA Assistant Lite bot.}

ventsislav-georgiev · 2026-03-25T23:11:32Z

I have read the CLA Document and I hereby sign the CLA

cubic-dev-ai

4 issues found across 3 files

Confidence score: 3/5

There is concrete cross-platform risk in src/features/opencode-skill-loader/opencode-config-skills-paths.ts: hardcoding ~/.config/opencode (severity 8/10, confidence 10/10) can miss the real global config location on Windows and other OS setups.
src/features/opencode-skill-loader/loader.ts may not wire newly discovered skills.paths into command registration, so skills could be found but not become executable commands (user-facing behavior gap).
The remaining findings are test-focused but still meaningful: src/features/opencode-skill-loader/opencode-config-skills-paths.test.ts has Windows JSONC escaping fragility and environment leakage into real global config, which can cause flaky/platform-dependent failures.
Pay close attention to src/features/opencode-skill-loader/opencode-config-skills-paths.ts, src/features/opencode-skill-loader/loader.ts, and src/features/opencode-skill-loader/opencode-config-skills-paths.test.ts - path resolution and command wiring need validation, and tests should be made platform-safe and isolated.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/features/opencode-skill-loader/opencode-config-skills-paths.ts">

<violation number="1" location="src/features/opencode-skill-loader/opencode-config-skills-paths.ts:13">
P1: Custom agent: **Opencode Compatibility**

Do not hardcode `~/.config/opencode` for OpenCode's global configuration directory. Use the shared `getOpenCodeConfigPaths` utility to ensure OS-specific paths (e.g., `%APPDATA%` on Windows, `Library/Application Support` on macOS) and environment variables like `OPENCODE_CONFIG_DIR` are respected, maintaining compatibility with OpenCode.</violation>
</file>

<file name="src/features/opencode-skill-loader/loader.ts">

<violation number="1" location="src/features/opencode-skill-loader/loader.ts:49">
P2: New `skills.paths` discovery is not wired into command registration, so those skills may not become executable commands.</violation>
</file>

<file name="src/features/opencode-skill-loader/opencode-config-skills-paths.test.ts">

<violation number="1" location="src/features/opencode-skill-loader/opencode-config-skills-paths.test.ts:72">
P2: Test is not environment-isolated: it can read real global `~/.config/opencode` config and fail on machines with `skills.paths` configured.</violation>

<violation number="2" location="src/features/opencode-skill-loader/opencode-config-skills-paths.test.ts:101">
P2: Raw Windows path interpolation creates invalid JSONC string escapes, making the JSONC test platform-dependent and likely to fail on Windows.</violation>
</file>

Since this is your first cubic review, here's how it works:

cubic automatically reviews your code and comments on bugs and improvements
Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
Ask questions if you need clarification on any suggestion

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/features/opencode-skill-loader/opencode-config-skills-paths.ts

src/features/opencode-skill-loader/loader.ts

src/features/opencode-skill-loader/opencode-config-skills-paths.test.ts

- Use getOpenCodeConfigDir() instead of hardcoded ~/.config/opencode for cross-platform and OPENCODE_CONFIG_DIR env support - Wire loadConfigPathsSkills into command-config-handler for proper command registration of skills.paths entries - Isolate tests from real global config via OPENCODE_CONFIG_DIR env - Fix Windows path escaping in JSONC test using JSON.stringify

cubic-dev-ai

1 issue found across 4 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/plugin-handlers/command-config-handler.ts">

<violation number="1" location="src/plugin-handlers/command-config-handler.ts:63">
P2: configPathsSkills is merged too early, giving it lower precedence than user/project/opencode skills; this conflicts with the documented priority (config paths should outrank project/user) and can cause config-path skills to be overridden.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/plugin-handlers/command-config-handler.ts

Move configPathsSkills after project commands/skills in the spread merge so it has higher precedence, matching the documented priority: opencode-project > opencode > config-paths > project > user.

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/plugin-handlers/command-config-handler.ts">

<violation number="1">
P1: Spread precedence regression: `systemCommands` now overrides project commands/skills due to reordered merge order.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/plugin-handlers/command-config-handler.ts

Move opencodeGlobal(Cmds+Skills) and systemCommands back before project commands, matching dev branch ordering. Fixes precedence regression where systemCommands was overriding project commands/skills.

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/plugin-handlers/command-config-handler.ts">

<violation number="1">
P2: Spread order now gives project/config-path commands higher precedence than opencode global/system, contradicting documented priority where opencode should override config paths/project. This behavior change can cause global/system commands to be silently overridden on name collisions.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/plugin-handlers/command-config-handler.ts

github-actions bot added a commit that referenced this pull request Mar 25, 2026

@ventsislav-georgiev has signed the CLA in #2840

ce1bffb

cubic-dev-ai bot reviewed Mar 25, 2026

View reviewed changes

cubic-dev-ai bot reviewed Mar 26, 2026

View reviewed changes

src/plugin-handlers/command-config-handler.ts Outdated Show resolved Hide resolved

ventsislav-georgiev added 2 commits March 26, 2026 11:31

fix: correct merge order for configPathsSkills precedence

037e8dd

Move configPathsSkills after project commands/skills in the spread merge so it has higher precedence, matching the documented priority: opencode-project > opencode > config-paths > project > user.

merge: resolve conflicts with dev (agents skills + configPaths ordering)

421a53c

cubic-dev-ai bot reviewed Mar 26, 2026

View reviewed changes

src/plugin-handlers/command-config-handler.ts Show resolved Hide resolved

fix: restore systemCommands merge position to match dev branch

13e3f6f

Move opencodeGlobal(Cmds+Skills) and systemCommands back before project commands, matching dev branch ordering. Fixes precedence regression where systemCommands was overriding project commands/skills.

cubic-dev-ai bot reviewed Mar 26, 2026

View reviewed changes

src/plugin-handlers/command-config-handler.ts Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(skill-loader): support skills.paths config for plugin skill discovery#2840

feat(skill-loader): support skills.paths config for plugin skill discovery#2840
ventsislav-georgiev wants to merge 5 commits intocode-yeongyu:devfrom
ventsislav-georgiev:feat/skills-paths-support

ventsislav-georgiev commented Mar 25, 2026 •

edited by cubic-dev-ai bot

Loading

Uh oh!

github-actions bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

ventsislav-georgiev commented Mar 25, 2026

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ventsislav-georgiev commented Mar 25, 2026 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Solution

Config example

Changes

Testing

Summary by cubic

Uh oh!

github-actions bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ventsislav-georgiev commented Mar 25, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ventsislav-georgiev commented Mar 25, 2026 •

edited by cubic-dev-ai bot

Loading

github-actions bot commented Mar 25, 2026 •

edited

Loading