Skip to content

fix(non-interactive-env): force unix prefix for bash git commands#2812

Merged
code-yeongyu merged 1 commit intodevfrom
fix/non-interactive-env-win-bash-prefix
Mar 24, 2026
Merged

fix(non-interactive-env): force unix prefix for bash git commands#2812
code-yeongyu merged 1 commit intodevfrom
fix/non-interactive-env-win-bash-prefix

Conversation

@code-yeongyu
Copy link
Copy Markdown
Owner

@code-yeongyu code-yeongyu commented Mar 24, 2026

Summary

  • force the non-interactive bash hook to always use Unix export syntax for git commands, even on win32 host shells
  • keep the fix hook-local so shared shell detection continues to behave normally for other consumers
  • verify the regression with targeted tests, typecheck, build, manual QA, and a full review-work pass

Testing

  • bun test src/hooks/non-interactive-env/index.test.ts
  • bun test src/shared/shell-env.test.ts
  • bun run typecheck
  • bun run build
  • manual QA: simulated win32 + PowerShell env still prints an export ...; git status command for the bash tool

Review

  • review-work: PASS
  • Goal verification: PASS
  • QA execution: PASS
  • Code quality: PASS
  • Security review: PASS
  • Context mining: PASS

Summary by cubic

Force Unix export prefix for non-interactive bash git commands to prevent prompts on Windows shells. Change is scoped to the non-interactive env hook; shared shell detection stays unchanged.

Written for commit e000a3b. Summary will update on new commits.

@code-yeongyu code-yeongyu merged commit cca057d into dev Mar 24, 2026
6 checks passed
@code-yeongyu code-yeongyu deleted the fix/non-interactive-env-win-bash-prefix branch March 24, 2026 16:24
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Forcing 'unix' syntax (export) over shell detection could cause regressions for users running git commands in native Windows shells like CMD or PowerShell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant