fix(background-task): apply model override omission to manager live path#2807
Merged
code-yeongyu merged 1 commit intodevfrom Mar 24, 2026
Merged
Conversation
Keep BackgroundManager launch and resume from sending both agent and model so OpenCode does not override configured subagent models. Add launch and resume regressions for the live production path. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <[email protected]>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The fix correctly implements conditional agent omission when a model override is provided, matching existing patterns and verified by new regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The agent-omission fix for explicit model override was in
spawner.ts, butmanager.ts(the actual production path) still sent bothagentandmodel, defeating the fix.Fix
Review
All 5 review-work lanes passed (goal, QA, code quality, security, context mining).
121/121 manager tests passed, typecheck passed, build passed.
Summary by cubic
Ensure explicit model overrides are honored in background tasks by omitting the agent when a model is provided in the manager’s live path. This prevents agent fallback from overriding user-selected models on launch and resume.
Written for commit 3b41191. Summary will update on new commits.