fix(config): prefer canonical plugin config filenames#2805
Merged
code-yeongyu merged 1 commit intodevfrom Mar 24, 2026
Merged
Conversation
Ensure oh-my-opencode filenames always win over legacy oh-my-openagent files so readers match canonical writer behavior. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <[email protected]>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Ensures consistent config detection by preferring canonical names while maintaining backward compatibility for legacy files. Minimal logic change with verifying tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
detectPluginConfigFile()preferredoh-my-openagent.jsonoveroh-my-opencode.jsonc(name before extension), while writers/installers canonicalize tooh-my-opencode. Users with both files got unpredictable behavior.Fix
oh-my-opencodefilenames always take precedence over legacyoh-my-openagentfilenames regardless of extension orderingReview
All 5 review-work lanes passed (goal, QA, code quality, security, context mining).
Tests passed, typecheck passed, build passed.
Summary by cubic
Prefer canonical
oh-my-opencodeplugin config files over legacyoh-my-openagent, regardless of.jsonvs.jsonc. This aligns readers with the writer/installer and removes confusion when both files exist.oh-my-opencodealways wins for both extensions.oh-my-opencode.jsonfor user and project configs.Written for commit 32035d1. Summary will update on new commits.