Skip to content

fix(category-resolver): respect is_unstable_agent config override (fixes #2061)#2799

Merged
code-yeongyu merged 1 commit intocode-yeongyu:devfrom
MoerAI:fix/unstable-agent-config-override
Mar 24, 2026
Merged

fix(category-resolver): respect is_unstable_agent config override (fixes #2061)#2799
code-yeongyu merged 1 commit intocode-yeongyu:devfrom
MoerAI:fix/unstable-agent-config-override

Conversation

@MoerAI
Copy link
Copy Markdown
Contributor

@MoerAI MoerAI commented Mar 24, 2026

Summary

  • Allow is_unstable_agent: false to override automatic model-name-based unstable detection for Gemini/Minimax/Kimi categories

Problem

The isUnstableAgent flag in category-resolver.ts uses a boolean OR (||) that unconditionally overrides explicit user configuration. When a user sets is_unstable_agent: false in their category config, the model name check (includes("gemini")) still forces isUnstableAgent = true. This routes all Gemini/Minimax/Kimi categories to the broken executeUnstableAgentTask() path, causing tasks to fail with 30-second timeouts.

Because false || true === true, the config option is completely non-functional.

Fix

Replaced || with nullish coalescing (??) so that explicit user configuration takes priority:

  • is_unstable_agent: true forces unstable path
  • is_unstable_agent: false forces stable path
  • undefined (no config) auto-detects from model name (preserves current default behavior)

Changes

File Change
src/tools/delegate-task/category-resolver.ts Changed `=== true

Fixes #2061


Summary by cubic

Respect is_unstable_agent in the category resolver so explicit false is honored, preventing Gemini/Minimax/Kimi categories from being forced into the unstable path and timing out. Fixes #2061.

  • Bug Fixes
    • Use nullish coalescing (??) instead of || to compute isUnstableAgent, so true/false config is respected.
    • Keep default behavior: when unset, auto-detect from model name (gemini, minimax, kimi).

Written for commit 41a43c6. Summary will update on new commits.

@MoerAI
Copy link
Copy Markdown
Contributor Author

MoerAI commented Mar 24, 2026

I have read the CLA Document and I hereby sign the CLA

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: The change correctly uses nullish coalescing to allow explicit 'false' configuration to override the model-based detection logic, which was previously impossible with the OR operator.

@code-yeongyu code-yeongyu merged commit 9c348db into code-yeongyu:dev Mar 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Gemini models forced into broken executeUnstableAgentTask path — tasks fail with 30s timeout

2 participants