fix(category-resolver): respect is_unstable_agent config override (fixes #2061)#2799
Merged
code-yeongyu merged 1 commit intocode-yeongyu:devfrom Mar 24, 2026
Merged
Conversation
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The change correctly uses nullish coalescing to allow explicit 'false' configuration to override the model-based detection logic, which was previously impossible with the OR operator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_unstable_agent: falseto override automatic model-name-based unstable detection for Gemini/Minimax/Kimi categoriesProblem
The
isUnstableAgentflag incategory-resolver.tsuses a boolean OR (||) that unconditionally overrides explicit user configuration. When a user setsis_unstable_agent: falsein their category config, the model name check (includes("gemini")) still forcesisUnstableAgent = true. This routes all Gemini/Minimax/Kimi categories to the brokenexecuteUnstableAgentTask()path, causing tasks to fail with 30-second timeouts.Because
false || true === true, the config option is completely non-functional.Fix
Replaced
||with nullish coalescing (??) so that explicit user configuration takes priority:is_unstable_agent: trueforces unstable pathis_unstable_agent: falseforces stable pathundefined(no config) auto-detects from model name (preserves current default behavior)Changes
src/tools/delegate-task/category-resolver.tsFixes #2061
Summary by cubic
Respect
is_unstable_agentin the category resolver so explicitfalseis honored, preventing Gemini/Minimax/Kimi categories from being forced into the unstable path and timing out. Fixes #2061.??) instead of||to computeisUnstableAgent, sotrue/falseconfig is respected.gemini,minimax,kimi).Written for commit 41a43c6. Summary will update on new commits.