fix(plugin): preserve selected model across messages#2797
Merged
code-yeongyu merged 1 commit intodevfrom Mar 24, 2026
Merged
Conversation
Reuse the current session's selected model during config-time agent rebuilds when config.model is missing, so desktop sessions do not snap back to the default model after each send. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <[email protected]>
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The changes safely introduce a fallback to session-scoped model state when configuration is missing, maintaining explicit precedence for user config with verified test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.modelis missing.config.modelprecedence unchanged, so direct UI-provided model selections still win when present.Verification
bun test src/plugin-handlers/agent-config-handler.test.tsbun test src/plugin-handlers/config-handler.test.ts src/plugin/chat-message.test.tsbun run typecheckbun run buildContext
config.modelwas absent.Summary by cubic
Preserves the user's selected model across messages by reusing the main session model during agent rebuilds when
config.modelis missing, fixing #2353. Explicitconfig.modelstill takes precedence.resolveCurrentModelto preferconfig.model, else fall back to the main session model fromgetMainSessionIDandgetSessionModel.applyAgentConfigto use the resolved model so sessions don’t snap back to the default after each send.config.model.Written for commit bad70f5. Summary will update on new commits.