fix(agents): preserve uiSelectedModel when agent override has no model (fixes #2351)#2788
Merged
code-yeongyu merged 1 commit intodevfrom Mar 24, 2026
Merged
Conversation
Three agent builder files used falsy checks that incorrectly nullified uiSelectedModel when override objects existed but had no model set: - sisyphus-agent.ts: `?.model ?` → `?.model !== undefined ?` - atlas-agent.ts: `?.model ?` → `?.model !== undefined ?` - general-agents.ts: `!override?.model` → `override?.model === undefined` This caused user model selection in web mode to revert to defaults. Fixes #2351
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Fixes truthiness bug by explicitly checking for undefined. This prevents empty strings or other falsy values in overrides from incorrectly triggering fallback logic.
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the second root cause from #2351 that PR #2670 missed.
Three agent builders used falsy checks that nullified uiSelectedModel:
sisyphusOverride?.model ?→sisyphusOverride?.model !== undefined ?orchestratorOverride?.model ?→orchestratorOverride?.model !== undefined ?!override?.model→override?.model === undefinedSupersedes #2670.
Summary by cubic
Preserves
uiSelectedModelwhen an agent override exists without amodel, preventing unwanted resets to default models. Replaces falsy checks with explicit undefined checks in the atlas, sisyphus, and general agent builders, fixing #2351.Written for commit d8fe611. Summary will update on new commits.