fix: respect disabled_tools config in agent prompts (fixes #2742)#2767
Merged
code-yeongyu merged 1 commit intodevfrom Mar 23, 2026
Merged
fix: respect disabled_tools config in agent prompts (fixes #2742)#2767code-yeongyu merged 1 commit intodevfrom
code-yeongyu merged 1 commit intodevfrom
Conversation
- Check disabled_tools for 'question' in tool-config-handler permission logic - Strip Question tool code examples from Prometheus prompts when disabled - Pass disabled_tools through prometheus agent config builder pipeline - Add tests for disabled_tools question permission handling
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 6 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Correctly implements tool stripping and permission denial for disabled tools with comprehensive tests, ensuring no regressions for existing configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
questiontool (and other tools) cannot be disabled viadisabled_toolsconfig because agent markdown prompts hardcode tool references regardless of user configuration.Fix
Check
disabled_toolslist when building agent system prompts. If a tool is in the disabled list, remove its references from the agent prompt.Fixes #2742
Automated fix by Sisyphus (oh-my-opencode)
Summary by cubic
Respect
disabled_toolsin agent prompts and permissions. Whenquestionis disabled, its prompt references are removed and the tool is denied for all agents. Fixes #2742.Question({...})examples from Prometheus system prompts whenquestionis disabled.disabled_toolsthrough the Prometheus agent config builder and use it intool-config-handlerto setquestionto "deny".Written for commit f5eaa64. Summary will update on new commits.