fix(keyword-detector): remove duplicate separator from ultrawork templates#2734
Merged
code-yeongyu merged 1 commit intocode-yeongyu:devfrom Mar 25, 2026
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Fixes a formatting issue by removing redundant separators from templates. Purely a string modification with no risk of logic regressions.
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
---separator from all 4 ultrawork template files (default, gpt, gemini, planner)hook.ts:120) already injects---between the injected message and the user's original text, causing a double---when ultrawork mode activatesProblem
The
keyword-detectorhook concatenates keyword messages with user text using:All ultrawork templates also end with
\n\n---\n\n, resulting in:The
searchandanalyzekeyword messages do not include a trailing---, producing the correct single separator. This inconsistency was introduced in the initial commit (64825158) and carried forward to all subsequent ultrawork variants (gpt, gemini, planner).Changes
Removed the trailing
\n\n---\n\nfrom the template string in each file, leaving\n\nso the hook's separator is the only one rendered.src/hooks/keyword-detector/ultrawork/default.tssrc/hooks/keyword-detector/ultrawork/gpt.tssrc/hooks/keyword-detector/ultrawork/gemini.tssrc/hooks/keyword-detector/ultrawork/planner.tsSummary by cubic
Removed the trailing
---from all ultrawork templates to prevent double separators when ultrawork mode activates. Thekeyword-detectorhook already inserts---between the injected message and the user's text, so only one divider is shown.Written for commit 07ea8de. Summary will update on new commits.