fix(atlas): address review findings for task session reuse#2676
Merged
code-yeongyu merged 1 commit intodevfrom Mar 18, 2026
Merged
fix(atlas): address review findings for task session reuse#2676code-yeongyu merged 1 commit intodevfrom
code-yeongyu merged 1 commit intodevfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 5 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Addresses review findings with safe hardening: prototype pollution guards, safe type narrowing, and broadened regex for IDs. Includes 12 new unit tests for the parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes for PR #2640 review findings (atlas task session reuse).
top-level-task.tsparser (12 test cases covering all edge cases)ses_[a-zA-Z0-9_-]+)__proto__/constructor/prototypeguard inupsertTaskSessionStateas string | undefinedcasts withtypeofnarrowing intool-execute-after.tsChanges
src/features/boulder-state/top-level-task.test.tssrc/hooks/atlas/subagent-session-id.tssrc/hooks/atlas/subagent-session-id.test.tssrc/features/boulder-state/storage.tssrc/hooks/atlas/tool-execute-after.tsVerification
bun run typecheck- passbun test top-level-task.test.ts subagent-session-id.test.ts- passbun test storage.test.ts- pass (regression)Summary by cubic
Follow-up fixes for Atlas task session reuse. Broadened session ID parsing, hardened task session storage, and removed unsafe casts; added comprehensive tests for the top-level task parser.
extractSessionIdFromOutput(regexses_[a-zA-Z0-9_-]+).upsertTaskSessionStateagainst__proto__,prototype, andconstructorkeys to prevent prototype pollution.typeofnarrowing foragentandcategorymetadata intool-execute-after.tsto replace unsafe casts.Written for commit 3c7e6a3. Summary will update on new commits.