fix(doctor): fall back to loadedVersion when pluginVersion is null#2596
Merged
acamq merged 1 commit intocode-yeongyu:devfrom Mar 16, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Surgical fix for diagnostic display issue; adds fallback to loaded version when others are null. No risk of functional regression.
Collaborator
|
LGTM! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oh-my-opencode unknownbecausepluginVersionhas no fallback toloadedVersionloadedVersionas third fallback in nullish coalescing chainCloses #2595
Change
src/cli/doctor/checks/system.ts— 1 line:Why
When
opencode.jsonregisters the plugin without a version ("oh-my-opencode") and the auto-updater syncs the cachepackage.jsonto use"latest"tag,normalizeVersion("latest")returnsnullbecause it only matches semver patterns. MeanwhileloadedVersioncorrectly reads"3.11.2"fromnode_modules/oh-my-opencode/package.jsonbut is never used for display.Summary by cubic
Fixes Doctor showing
oh-my-opencode unknownby falling back to the loaded plugin version when pinned/expected versions are missing. Ensures the real installed version shows even whenopencode.jsonuseslatest.src/cli/doctor/checks/system.ts, computepluginVersionaspinnedVersion ?? expectedVersion ?? loadedVersion(Closes fix(doctor): plugin version shows "unknown" when cache uses dist-tag #2595).Written for commit 5b7ca99. Summary will update on new commits.