fix(agents): include config agents and migrated plugin agents in customAgentSummaries#2585
Merged
acamq merged 1 commit intocode-yeongyu:devfrom Mar 15, 2026
Conversation
…omAgentSummaries PR code-yeongyu#2424 fixed the critical bug (passing client object instead of agent summaries array), but only included user, project, and raw plugin agents. This adds the two missing sources: - OpenCode native config agents (params.config.agent) - Plugin agents with migrateAgentConfig applied before summary extraction Ensures Sisyphus has complete awareness of all registered agent sources. Closes code-yeongyu#2386 Co-authored-by: NS Cola <[email protected]>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Correctly reorders logic to include migrated plugin agents and config agents in summaries. Reordering is safe as dependencies are available. Includes safety null checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2424 which fixed the critical
customAgentSummariesbug (passing client object instead of array). That fix covered user, project, and raw plugin agents but missed two sources:params.config.agent) — agents defined directly in OpenCode's config were not included in Sisyphus's summariesmigrateAgentConfigwas not applied to plugin agents before summary extraction, so legacy field names could produce empty descriptionsChanges
In
src/plugin-handlers/agent-config-handler.ts:pluginAgents(withmigrateAgentConfig) andconfigAgentextraction beforecustomAgentSummariesconstructionconfigAgent,userAgents,projectAgents,pluginAgents.filter(([, config]) => config != null)) for safetycreateBuiltinAgentsContext
Three PRs attempted to fix #2386:
config.agentsource, but accumulated merge conflictsThis PR cherry-picks the completeness improvement from #2392's analysis. Supersedes #2392.
Related Issues
Co-authored-by: @davincilll
Summary by cubic
Include config-defined agents and migrated plugin agents in
customAgentSummariesso Sisyphus sees all registered agents and descriptions. Fixes missing summaries fromparams.config.agentand legacy plugin plugin configs.configAgent,userAgents,projectAgents,pluginAgents.migrateAgentConfigbefore extracting summaries and add null guards.customAgentSummariesand remove duplicates.Written for commit e8a3e54. Summary will update on new commits.