fix(doctor): count intelephense in LSP detection#2572
Closed
idrekdon wants to merge 1 commit intocode-yeongyu:devfrom
Closed
fix(doctor): count intelephense in LSP detection#2572idrekdon wants to merge 1 commit intocode-yeongyu:devfrom
idrekdon wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
Align the doctor LSP summary with existing PHP support so Laravel and PHP setups do not get a false missing-LSP warning. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Simple addition of PHP LSP detection to a static list. No logic changes or complex code paths affected. Low risk of regression.
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
This was referenced Mar 16, 2026
Collaborator
|
Closing as superseded by #2588. Thank you for contributing. Feel free to open more PRs for other issues! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
oh-my-opencode doctorreportsNo LSP servers detectedin PHP/Laravel environments even whenintelephenseis installed and PHP LSP support is available elsewhere in the package.Current behavior
doctoronly counts these LSP binaries insrc/cli/doctor/checks/tools-lsp.ts:typescript-language-serverpyright-langserverrust-analyzergoplsThat means a PHP-only setup can show
LSP 0/4 installedand emit this warning:Why this is misleading
PHP support already exists via
intelephense, so the doctor output does not match actual supported runtime behavior. In practice, PHP/Laravel users can have working LSP tooling whiledoctorstill says no LSP servers are installed.Proposed fix
Add PHP to the doctor detection list:
Summary by cubic
Teach
oh-my-opencode doctorto detect PHP by countingintelephenseas an LSP server. Fixes false "No LSP servers detected" warnings in PHP/Laravel environments and aligns the LSP summary with existing PHP support.Written for commit c162ebb. Summary will update on new commits.