fix: union disabled_tools in mergeConfigs() like other disabled_* arrays#2559
Merged
acamq merged 1 commit intocode-yeongyu:devfrom Mar 15, 2026
Merged
Conversation
disabled_tools was defined in the Zod schema but omitted from mergeConfigs(), causing project-level config to shadow user-level disabled_tools instead of merging both sets. Add Set union and regression test. Closes code-yeongyu#2555
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The PR correctly fixes an inconsistency by applying the established Set-based union pattern to disabled_tools, supported by a new regression test.
Collaborator
|
LGTM. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disabled_toolswas defined inOhMyOpenCodeConfigSchema(Zod) but omitted frommergeConfigs(), causing project-level config to shadow user-leveldisabled_toolsinstead of preserving bothdisabled_toolsfollowing the exact same pattern as the other 5disabled_*arraysChanges
src/plugin-config.ts: Adddisabled_toolsSet union inmergeConfigs()(5 lines, betweendisabled_skillsandclaude_code)src/plugin-config.test.ts: Add test case fordisabled_toolsmerge with overlapTesting
bun test src/plugin-config.test.ts— 12/12 pass (was 11 before this change)["todowrite", "interactive_bash"]+ override["interactive_bash", "look_at"]→ merged result["todowrite", "interactive_bash", "look_at"](3 items, no duplicates)Closes #2555
Summary by cubic
Fix the merge of
disabled_toolsinmergeConfigs()so user and project configs are unioned and deduplicated, matching otherdisabled_*arrays; closes #2555. Adds a regression test for overlapping lists.Written for commit 9a774f1. Summary will update on new commits.