fix(agents): add termination criteria to Sisyphus-Junior default#2544
Merged
code-yeongyu merged 1 commit intocode-yeongyu:devfrom Mar 25, 2026
Merged
fix(agents): add termination criteria to Sisyphus-Junior default#2544code-yeongyu merged 1 commit intocode-yeongyu:devfrom
code-yeongyu merged 1 commit intocode-yeongyu:devfrom
Conversation
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The change is a prompt-only addition to prevent loops. It has no code logic changes, passes all tests, and addresses a specific reliability issue without risk of regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes status-checking loops in the quick category agent by adding explicit termination criteria to
default.ts.Problem
The quick agent (used by Nemotron, GLM 4.7 Flash, and other non-GPT models) exhibited "completion anxiety" loops:
Root Cause
The Sisyphus-Junior
default.tsprompt tells the agent what to verify, but not when to stop:Missing: Termination criteria. The agent keeps verifying because no one told it to stop after first success.
Model routing context:
gpt.ts(has some termination guidance)gemini.tsdefault.ts(this fix)Solution
Added
<Termination>section tosrc/agents/sisyphus-junior/default.ts:Changes
src/agents/sisyphus-junior/default.tsTesting