fix(delegate-task): report the real background task id#2533
Merged
code-yeongyu merged 1 commit intocode-yeongyu:devfrom Mar 25, 2026
Merged
fix(delegate-task): report the real background task id#2533code-yeongyu merged 1 commit intocode-yeongyu:devfrom
code-yeongyu merged 1 commit intocode-yeongyu:devfrom
Conversation
Keep background task metadata aligned with the background_output contract so callers do not pass a session id where the task manager expects a background task id. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Fixes an obvious incorrect variable usage where session_id was being used for task_id in metadata. Changes are minimal, isolated, and verified with tests.
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<task_metadata>instead of repeating the subagent session id undertask_idbackground_output(task_id=...)aligned with the metadata block that background task producers returnValidation
npx -y [email protected] test src/tools/delegate-task/background-task.test.ts src/tools/delegate-task/tools.test.tsnpx -y [email protected] run typecheckNotes
#2524); it only touches delegate-task background metadata formattingSummary by cubic
Fixes delegate-task metadata to emit the actual background task ID instead of the session ID. Keeps
<task_metadata>aligned with thebackground_output(task_id=...)contract so callers pass the correct ID.task_idin<task_metadata>to the background task ID;session_idremains unchanged.task_idandbackground_task_idboth reflect the launched task.Written for commit 1e0823a. Summary will update on new commits.