fix(config): preserve formatter config from opencode settings#2147
Merged
code-yeongyu merged 1 commit intodevfrom Feb 26, 2026
Merged
fix(config): preserve formatter config from opencode settings#2147code-yeongyu merged 1 commit intodevfrom
code-yeongyu merged 1 commit intodevfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Restoring the 'formatter' field at the end of the pipeline could overwrite legitimate modifications or additions made by intermediate handlers, violating the '100% no regressions' criteria.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Formatters defined in opencode's configuration don't work because the oh-my-opencode plugin drops the
formatterfield during config processing.Root Cause
config-handler.tsdoesn't preserve theformatterfield when processing OpenCode configuration.Fix
Preserve the formatter configuration in the config handler pipeline.
Test
src/plugin-handlers/config-handler-formatter.test.tsto verify both object andfalseformatter values are preserved.Closes #2117
Summary by cubic
Preserves the formatter setting from OpenCode config in the oh-my-opencode config handler so configured formatters are respected. Closes #2117.
Written for commit 7ff8352. Summary will update on new commits.