options: add Unsafe.AllowMissingWALDir option#5478
Merged
RaduBerinde merged 1 commit intocockroachdb:masterfrom Oct 23, 2025
Merged
options: add Unsafe.AllowMissingWALDir option#5478RaduBerinde merged 1 commit intocockroachdb:masterfrom
RaduBerinde merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Member
Author
|
CC @annikiforov - this should address your problem, correct? |
This unsafe option allows opening a store after moving or losing the previous WAL dir. This is understood to be risky and have associated data loss if any of the necessary WALs are not in the new directory. Fixes cockroachdb#5421
RaduBerinde
force-pushed
the
allow-missing-wal-dirs
branch
from
4a14f92 to
6cf1e8a
Compare
Absolutely, perfect! |
xinhaoz
approved these changes
Oct 23, 2025
Contributor
xinhaoz
left a comment
xinhaoz
left a comment
There was a problem hiding this comment.
@xinhaoz reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jbowens)
Member
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unsafe option allows opening a store after moving or losing the
previous WAL dir. This is understood to be risky and have associated
data loss if any of the necessary WALs are not in the new directory.
Fixes #5421