block: fix off-by-one bug in CompressionStats#5262
Merged
RaduBerinde merged 1 commit intocockroachdb:pebble-release-2.1from Sep 4, 2025
Merged
Conversation
Member
|
This change is |
xinhaoz
approved these changes
Sep 2, 2025
CompressionStats is supposed to hold up to four settings but because of an off-by-one bug it only allows three. The "built-in" profiles use at most three, but it is possible for a user to define their own profile which might require four. Fix and add a test. Informs cockroachdb#5260
RaduBerinde
force-pushed
the
fix-compression-stats-panic
branch
from
9ba7926 to
9c53d71
Compare
Member
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompressionStats is supposed to hold up to four settings but because of an off-by-one bug it only allows three. The "built-in" profiles use at most three, but it is possible for a user to define their own profile which might require four.
Fix and add a test.
Informs #5260