sql: check row level ttl change before truncating a table#98537
Conversation
|
This change is |
| SELECT id FROM system.namespace WHERE name = 't1'; | ||
|
|
||
| statement ok | ||
| WITH to_json AS ( |
There was a problem hiding this comment.
doing manual mutation upsert instead of using pausing points because it takes too long for a test to run.
There was a problem hiding this comment.
🤔 if you set the cluster settings like this it should be faster:
cockroach/pkg/sql/logictest/testdata/logic_test/create_index
Lines 252 to 257 in 724598b
My sense is that it'd make for a better test.
There was a problem hiding this comment.
oh wow. that does help. will update it.
chengxiong-ruan
force-pushed
the
check-row-ttl-mutation-when-truncate
branch
from
7beb7ac to
5759164
Compare
Fixes: cockroachdb#93443 Release note (sql change): This commit fixed a bug where crdb paniced wehn user tried to truncate a table which is has an ongoing row level ttl change. We still don't support table truncates in this scenario, but a more gentle unimplemented error is returned instead of panic.
chengxiong-ruan
force-pushed
the
check-row-ttl-mutation-when-truncate
branch
from
5759164 to
05f5bf2
Compare
|
TFTR! |
|
Build failed (retrying...): |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 05f5bf2 to blathers/backport-release-22.2-98537: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
3 participants
Fixes: #93443
Release note (sql change): This commit fixed a bug where crdb paniced wehn user tried to truncate a table which is has an ongoing row level ttl change. We still don't support table truncates in this scenario, but a more gentle unimplemented error is returned instead of panic.