util/mon: remove nameWithPointer to reduce allocations#86954
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 26, 2022
Merged
util/mon: remove nameWithPointer to reduce allocations#86954craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This field was added in order to help us track down some of the memory leaks which we have already found, and the field didn't turn out to be that useful. When it was introduced, the implications on the increase in allocations were unknown, and now I don't think the field is worth it. ``` name old time/op new time/op delta FlowSetup/vectorize=true/distribute=true-24 168µs ± 5% 164µs ± 4% -2.33% (p=0.007 n=19+20) FlowSetup/vectorize=true/distribute=false-24 167µs ± 6% 164µs ± 6% ~ (p=0.060 n=20+20) FlowSetup/vectorize=false/distribute=true-24 163µs ± 4% 161µs ± 7% ~ (p=0.057 n=19+20) FlowSetup/vectorize=false/distribute=false-24 161µs ± 6% 159µs ± 5% ~ (p=0.309 n=19+20) name old alloc/op new alloc/op delta FlowSetup/vectorize=true/distribute=true-24 19.6kB ± 8% 19.0kB ± 8% -2.62% (p=0.001 n=19+18) FlowSetup/vectorize=true/distribute=false-24 18.2kB ± 1% 17.7kB ± 1% -2.56% (p=0.000 n=17+16) FlowSetup/vectorize=false/distribute=true-24 25.8kB ± 2% 25.4kB ± 0% -1.44% (p=0.000 n=16+16) FlowSetup/vectorize=false/distribute=false-24 24.7kB ± 0% 24.4kB ± 1% -1.36% (p=0.000 n=16+16) name old allocs/op new allocs/op delta FlowSetup/vectorize=true/distribute=true-24 218 ± 2% 205 ± 3% -5.64% (p=0.000 n=19+19) FlowSetup/vectorize=true/distribute=false-24 208 ± 1% 197 ± 3% -5.63% (p=0.000 n=19+19) FlowSetup/vectorize=false/distribute=true-24 206 ± 0% 197 ± 0% -4.40% (p=0.000 n=16+16) FlowSetup/vectorize=false/distribute=false-24 197 ± 0% 188 ± 0% -4.54% (p=0.000 n=16+16) ``` Release justification: low-risk cleanup. Release note: None
Member
michae2
approved these changes
Aug 26, 2022
Collaborator
michae2
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Member
Author
|
TFTR! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This was referenced Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This field was added in order to help us track down some of the memory
leaks which we have already found, and the field didn't turn out to be
that useful. When it was introduced, the implications on the increase in
allocations were unknown, and now I don't think the field is worth it.
Release justification: low-risk cleanup.
Release note: None