Skip to content

roachtest: automatically profile CPU in restore tests#111434

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
pav-kv:auto-cpu-profile-in-restore
Sep 28, 2023
Merged

roachtest: automatically profile CPU in restore tests#111434
craig[bot] merged 1 commit intocockroachdb:masterfrom
pav-kv:auto-cpu-profile-in-restore

Conversation

@pav-kv
Copy link
Copy Markdown
Collaborator

@pav-kv pav-kv commented Sep 28, 2023 •
edited
Loading

See https://www.cockroachlabs.com/docs/v23.1/automatic-cpu-profiler.

NB: the server.cpu_profile.enabled setting is not used because it was recently removed in #107717. It should be used if this change is backported.

Touches #111160, #111159
Epic: none
Release note: none

@pav-kv pav-kv requested review from msbutler and rhu713 September 28, 2023 17:48
@pav-kv pav-kv requested a review from a team as a code owner September 28, 2023 17:48
@pav-kv pav-kv requested review from DarrylWong and herkolategan and removed request for a team September 28, 2023 17:48
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Sep 28, 2023

This change is Reviewable

@pav-kv
Copy link
Copy Markdown
Collaborator Author

pav-kv commented Sep 28, 2023 •
edited
Loading

Example of a successful test run (restore/tpce/8TB/aws/nodes=10/cpus=8):

Screenshot 2023-09-28 at 19 02 43

CPU peaked at almost 79%. So, the default recommended threshold of 80% makes sense.

@pav-kv pav-kv mentioned this pull request Sep 28, 2023
Closed
@pav-kv pav-kv added the backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only label Sep 28, 2023
@pav-kv
Copy link
Copy Markdown
Collaborator Author

pav-kv commented Sep 28, 2023

bors r=msbutler

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 28, 2023

Build succeeded:

@craig craig bot merged commit 39614e9 into cockroachdb:master Sep 28, 2023
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Sep 28, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error creating merge commit from c516881 to blathers/backport-release-23.1-111434: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@pav-kv pav-kv deleted the auto-cpu-profile-in-restore branch September 29, 2023 09:24
@pav-kv pav-kv mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msbutler msbutler msbutler approved these changes

@rhu713 rhu713 Awaiting requested review from rhu713

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan was automatically assigned from cockroachdb/test-eng

@DarrylWong DarrylWong Awaiting requested review from DarrylWong DarrylWong was automatically assigned from cockroachdb/test-eng

Assignees

No one assigned

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pav-kv @cockroach-teamcity @msbutler